1341962 - ccache stats parser breaks with ccache 3.3.3

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

+++ This bug was initially created as a clone of Bug #1309657 +++

I upgrade to ccache 3.3.3 on Mac, and have the following error.

5:03.35 Failed to parse ccache stats output: unsupported code directive             2

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1341962 - Update ccache stats parser for version 3.3.3.

The "unsupported code directive" is added to the 'ccache -s' output in
https://github.com/ccache/ccache/commit/b6d7cf55028c4e23778fb02595e7d1ee6596a5a8

We need to teach our parser for it.

Review commit: https://reviewboard.mozilla.org/r/114766/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/114766/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8840276 [details]
Bug 1341962 - Update ccache stats parser for version 3.3.3.

https://reviewboard.mozilla.org/r/114766/#review117642

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a15e34e2d22
Update ccache stats parser for version 3.3.3. r=glandium

Comment 4

[Iris Hsiao [:ihsiao]]

Backed this out for build bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=80736634&repo=autoland&lineNumber=22511

https://hg.mozilla.org/integration/autoland/rev/e1b741382dc0

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Comment on attachment 8840276 [details]
Bug 1341962 - Update ccache stats parser for version 3.3.3.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/114766/diff/1-2/

Comment 6

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

I rebase my patch, and delete the stats_diff test because this patch just updated the parser to recognize a new field, which is not relevant for us for displaying the ccache status. A parsing test to the new format should be sufficient.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/786dcb25ee48
Update ccache stats parser for version 3.3.3. r=glandium

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/786dcb25ee48