Closed Bug 1342022 Opened 7 years ago Closed 7 years ago

Remove useless a "using" declaration in WebrtcTelemetry.cpp

Categories

(Developer Infrastructure :: Source Code Analysis, defect, P3)

defect

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: l1peu2tout, Assigned: l1peu2tout)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Running some toolings, I found that an "using" declaration is useless.
Attached patch bug1342022.diffSplinter Review
Attachment #8840406 - Flags: review?(gfritzsche)
Assignee: nobody → l1peu2tout
Thanks for looking into those.
For straight-forward replacements like this, it would be more efficient to do multiple or all in one bug (i see e.g. bug 1342032).
This shouldn't need special review everywhere.
Flags: needinfo?(l1peu2tout)
Comment on attachment 8840406 [details] [diff] [review]
bug1342022.diff

Review of attachment 8840406 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me, thanks.
Attachment #8840406 - Flags: review?(gfritzsche) → review+
No try push needed here.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: checkin-needed
Priority: -- → P3
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11a711ac2407
Remove useless a "using" declaration in WebrtcTelemetry.cpp. r=gfritzsche
Keywords: checkin-needed
Ok, I will do that next time, thanks.
Flags: needinfo?(l1peu2tout)
https://hg.mozilla.org/mozilla-central/rev/11a711ac2407
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Product: Core → Firefox Build System
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.