Remove ProtectedReallocPolicy when we're done using it

RESOLVED FIXED in Firefox 56

Status

()

defect
P2
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: ehoogeveen, Assigned: ehoogeveen)

Tracking

Trunk
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

ProtectedReallocPolicy in ds/PageProtectingVector.h is becoming more and more specialized, and its internals have already changed several times. After we're done using it to debug bug 1124397 we should remove it.
Marking this P2 for now, though I suspect we'll be done with it soon.
Priority: -- → P2
I think it's about time. We still don't know what's going wrong in jemalloc but we've narrowed down the problem as much as we can and it's clear that the Windows crashes are due to bad hardware. The only disadvantage to removing this code is that the crashes will move to a different signature, but we never enabled this on Beta or Release anyway.
Attachment #8889915 - Flags: review?(jdemooij)
And remove the rest. I think this is everything, try run to make sure: https://treeherder.mozilla.org/#/jobs?repo=try&revision=63d898a06c26ad440d254d9bdb55b6b0fc19d68a

This should be a nice speedup for certain cases on Nightly, though I don't expect anything too major.
Attachment #8889916 - Flags: review?(jdemooij)
Comment on attachment 8889915 [details] [diff] [review]
Part 1: Remove ProtectedReallocPolicy from PageProtectingVector.

Review of attachment 8889915 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8889915 - Flags: review?(jdemooij) → review+
Comment on attachment 8889916 [details] [diff] [review]
Part 2: Stop using PageProtectingVector in AssemblerBuffer.

Review of attachment 8889916 [details] [diff] [review]:
-----------------------------------------------------------------

Will be interesting to see if this helps perf somewhere :)
Attachment #8889916 - Flags: review?(jdemooij) → review+
I actually missed a few instances, ARM mostly. Guess Try didn't catch it because they were all no ops. Trivial change, carrying forward r+.
Attachment #8889916 - Attachment is obsolete: true
Attachment #8890411 - Flags: review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/20da293c7656
Part 1: Remove ProtectedReallocPolicy from PageProtectingVector. r=jandem
https://hg.mozilla.org/integration/mozilla-inbound/rev/3144b8254557
Part 2: Stop using PageProtectingVector in AssemblerBuffer. r=jandem
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/20da293c7656
https://hg.mozilla.org/mozilla-central/rev/3144b8254557
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.