1342105 - Crash in java.lang.NullPointerException: Attempt to invoke virtual method ''char java.lang.String.charAt(int)'' on a null object reference at android.graphics.Color.parseColor(Color.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This bug was filed from the Socorro interface and is 
report bp-4cbd3bcc-5e73-4a21-ae45-a196e2170222.
=============================================================

I think we're supposed to return after this line [1], otherwise a null `backgroundColorString` causes this crash right after that.

[1] http://searchfox.org/mozilla-central/rev/b1044cf7c2000c3e75e8181e893236a940c8b6d2/mobile/android/base/java/org/mozilla/gecko/icons/loader/SuggestedSiteLoader.java#64

Comment 1

[Andrzej Hunt :ahunt]

(In reply to Jim Chen [:jchen] [:darchons] from comment #0)
> This bug was filed from the Socorro interface and is 
> report bp-4cbd3bcc-5e73-4a21-ae45-a196e2170222.
> =============================================================
> 
> I think we're supposed to return after this line [1], otherwise a null
> `backgroundColorString` causes this crash right after that.
> 
> [1]
> http://searchfox.org/mozilla-central/rev/
> b1044cf7c2000c3e75e8181e893236a940c8b6d2/mobile/android/base/java/org/
> mozilla/gecko/icons/loader/SuggestedSiteLoader.java#64

Ughh yeah, I messed that up...

Comment 2

[Andrzej Hunt :ahunt]

Attachment: Bug 1342105 - actually return if suggested site data is missing

Review commit: https://reviewboard.mozilla.org/r/114970/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/114970/

Comment 3

[Andrzej Hunt :ahunt]

It's unclear why we're even hitting this scenario though - I've filed Bug 1342136 to look into that.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8840497 [details]
Bug 1342105 - actually return if suggested site data is missing

https://reviewboard.mozilla.org/r/114970/#review117744

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/093c7e787c9b
actually return if suggested site data is missing r=sebastian

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/093c7e787c9b