Closed Bug 1342105 Opened 7 years ago Closed 7 years ago

Crash in java.lang.NullPointerException: Attempt to invoke virtual method ''char java.lang.String.charAt(int)'' on a null object reference at android.graphics.Color.parseColor(Color.java)

Categories

(Firefox for Android Graveyard :: General, defect, P1)

All
Android
defect

Tracking

(firefox52 unaffected, firefox53 unaffected, firefox54 fixed)

RESOLVED FIXED
Firefox 54
Tracking Status
firefox52 --- unaffected
firefox53 --- unaffected
firefox54 --- fixed

People

(Reporter: jchen, Assigned: ahunt)

References

Details

(Keywords: crash, Whiteboard: [MobileAS])

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-4cbd3bcc-5e73-4a21-ae45-a196e2170222.
=============================================================

I think we're supposed to return after this line [1], otherwise a null `backgroundColorString` causes this crash right after that.

[1] http://searchfox.org/mozilla-central/rev/b1044cf7c2000c3e75e8181e893236a940c8b6d2/mobile/android/base/java/org/mozilla/gecko/icons/loader/SuggestedSiteLoader.java#64
Flags: needinfo?(ahunt)
(In reply to Jim Chen [:jchen] [:darchons] from comment #0)
> This bug was filed from the Socorro interface and is 
> report bp-4cbd3bcc-5e73-4a21-ae45-a196e2170222.
> =============================================================
> 
> I think we're supposed to return after this line [1], otherwise a null
> `backgroundColorString` causes this crash right after that.
> 
> [1]
> http://searchfox.org/mozilla-central/rev/
> b1044cf7c2000c3e75e8181e893236a940c8b6d2/mobile/android/base/java/org/
> mozilla/gecko/icons/loader/SuggestedSiteLoader.java#64

Ughh yeah, I messed that up...
Assignee: nobody → ahunt
Iteration: --- → 1.16
Flags: needinfo?(ahunt)
Priority: -- → P1
Whiteboard: [MobileAS]
It's unclear why we're even hitting this scenario though - I've filed Bug 1342136 to look into that.
Comment on attachment 8840497 [details]
Bug 1342105 - actually return if suggested site data is missing

https://reviewboard.mozilla.org/r/114970/#review117744
Attachment #8840497 - Flags: review?(s.kaspari) → review+
Pushed by ahunt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/093c7e787c9b
actually return if suggested site data is missing r=sebastian
https://hg.mozilla.org/mozilla-central/rev/093c7e787c9b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.