Open Bug 1342132 Opened 4 years ago Updated 2 years ago

Location bar suggestions not having a title look bad

Categories

(Firefox :: Address Bar, defect, P3)

defect

Tracking

()

Tracking Status
firefox54 --- affected

People

(Reporter: mak, Unassigned)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Attached image Screenshot (24).png
Entries not having a title just repeat twice the stripped url, and that looks pointless and ugly.

Notice the 5th entry in the screenshot.

Hi, I am willing to work on this, can you please give me a hint.

Flags: needinfo?(mak77)

Unfortunately this requires some design hints we don't have yet. I suspect we should add a "notitle" attribute to the row, and hide both the title and the separator boxes if the attribute is set (should be set if title and url are the same). The "bookmark without title but with tags" case must be considered appropriately to not look ugly...
Considered we are head down on the Quantum Bar rewrite, I don't think it's worth fixing this in the old implementation.

If you want to play with it, the code lives here
https://searchfox.org/mozilla-central/rev/2f1020dc4176d38dd5f3d0496f3c46849862ee0b/browser/components/urlbar/UrlbarView.jsm#386
and it can be enabled in Nightly (or mozilla-central) setting browser.urlbar.quantumbar = true

Flags: needinfo?(mak77)
You need to log in before you can comment on or make changes to this bug.