1342170 - Fails to build with FILES_PER_UNIFIED_FILE = 1 set in js/src/moz.build

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Yury Delendik (:yury)]

Latest m-c when build with FILES_PER_UNIFIED_FILE=1  (configure --disable-optimize --enable-debug --enable-warnings-as-errors) fails with following:

In file included from /Users/yury/Work/mozilla-central/js/src/jit/BaselineCacheIRCompiler.cpp:7:
In file included from /Users/yury/Work/mozilla-central/js/src/jit/BaselineCacheIRCompiler.h:11:
In file included from /Users/yury/Work/mozilla-central/js/src/jit/CacheIR.h:16:
In file included from /Users/yury/Work/mozilla-central/js/src/jit/SharedIC.h:11:
/Users/yury/Work/mozilla-central/js/src/jscompartment.h:465:30: error: inline function 'JSCompartment::maybeGlobal' is not defined
      [-Werror,-Wundefined-inline]
    inline js::GlobalObject* maybeGlobal() const;
                             ^
/Users/yury/Work/mozilla-central/js/src/jit/CacheIR.h:515:45: note: used here
        addStubField(uintptr_t(compartment->maybeGlobal()), StubField::Type::JSObject);
                                            ^
----

In file included from /Users/yury/Work/mozilla-central/js/src/vm/ArgumentsObject.cpp:7:
In file included from /Users/yury/Work/mozilla-central/js/src/vm/ArgumentsObject-inl.h:10:
In file included from /Users/yury/Work/mozilla-central/js/src/vm/ArgumentsObject.h:13:
/Users/yury/Work/mozilla-central/js/src/vm/NativeObject.h:481:5: error: inline function 'js::NativeObject::create' is not defined
      [-Werror,-Wundefined-inline]
    create(JSContext* cx, js::gc::AllocKind kind, js::gc::InitialHeap heap,
    ^
/Users/yury/Work/mozilla-central/js/src/vm/ArgumentsObject.cpp:232:55: note: used here
    JS_TRY_VAR_OR_RETURN_NULL(cx, base, NativeObject::create(cx, FINALIZE_KIND, gc::TenuredHeap,
                                                      ^

First one regressed by bug 1319087 and second one by bug 1339411.

Comment 1

[Yury Delendik (:yury)]

Attachment: Bug 1342170 - Fixes jscompartment inlines for js/src/jit files.

Review commit: https://reviewboard.mozilla.org/r/115024/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115024/

Comment 2

[Yury Delendik (:yury)]

Attachment: Bug 1342170 - Fixes NativeObject::create inlines for js/src/vm/ files.

Review commit: https://reviewboard.mozilla.org/r/115026/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115026/

Comment 3

[Ryan VanderMeulen (PTO, back July 27)]

Odd that SM(nu) didn't catch this in automation. Unless there's something platform/compiler specific going on here.

Comment 4

[Tom S. (please needinfo tschuster)]

Comment on attachment 8840533 [details]
Bug 1342170 - Fixes jscompartment inlines for js/src/jit files.

https://reviewboard.mozilla.org/r/115024/#review116494

Comment 5

[Yury Delendik (:yury)]

Attachment: Bug 1342170 - Enable Werror for SM(nu).

Review commit: https://reviewboard.mozilla.org/r/115028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115028/

Comment 6

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8840551 [details]
Bug 1342170 - Enable Werror for SM(nu).

https://reviewboard.mozilla.org/r/115028/#review116518

Comment 7

[Steve Fink [:sfink] [:s:]]

Attachment: Display compile commands for shell builds

Comment 8

[Steve Fink [:sfink] [:s:]]

Attachment: Display compile commands for shell builds

Oops, got that backwards.

Comment 9

[Yury Delendik (:yury)]

Comment on attachment 8840533 [details]
Bug 1342170 - Fixes jscompartment inlines for js/src/jit files.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115024/diff/1-2/

Comment 10

[Yury Delendik (:yury)]

Comment on attachment 8840534 [details]
Bug 1342170 - Fixes NativeObject::create inlines for js/src/vm/ files.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115026/diff/1-2/

Comment 11

[Yury Delendik (:yury)]

Comment on attachment 8840551 [details]
Bug 1342170 - Enable Werror for SM(nu).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115028/diff/1-2/

Comment 12

[Jan de Mooij [:jandem]]

Comment on attachment 8840534 [details]
Bug 1342170 - Fixes NativeObject::create inlines for js/src/vm/ files.

https://reviewboard.mozilla.org/r/115026/#review116726

r=me with nit below addressed.

::: js/src/vm/ArgumentsObject.cpp:19
(Diff revision 2)
>  #include "vm/Stack.h"
>  
>  #include "jsobjinlines.h"
>  
>  #include "gc/Nursery-inl.h"
> +#include "vm/NativeObject-inl.h"

Nit: NativeObject should come before Nursery or the style checker will complain.

Comment 13

[Jan de Mooij [:jandem]]

(In reply to Jan de Mooij [:jandem] from comment #12)
> Nit: NativeObject should come before Nursery or the style checker will
> complain.

Sorry my bad, it's gc/ vs vm/ so this is fine. Thanks for fixing!

Comment 14

[Yury Delendik (:yury)]

Attachment: Bug 1342170 - Display compile commands for shell builds.

Review commit: https://reviewboard.mozilla.org/r/115334/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115334/

Comment 15

[Yury Delendik (:yury)]

Comment on attachment 8840533 [details]
Bug 1342170 - Fixes jscompartment inlines for js/src/jit files.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115024/diff/2-3/

Comment 16

[Yury Delendik (:yury)]

Comment on attachment 8840534 [details]
Bug 1342170 - Fixes NativeObject::create inlines for js/src/vm/ files.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115026/diff/2-3/

Comment 17

[Yury Delendik (:yury)]

Comment on attachment 8840551 [details]
Bug 1342170 - Enable Werror for SM(nu).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115028/diff/2-3/

Comment 18

[Ryan VanderMeulen (PTO, back July 27)]

Comment on attachment 8840958 [details]
Bug 1342170 - Display compile commands for shell builds.

https://reviewboard.mozilla.org/r/115334/#review116776

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/405f930ae1b7
Fixes jscompartment inlines for js/src/jit files. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/974fa9a5049d
Fixes NativeObject::create inlines for js/src/vm/ files. r=jandem
https://hg.mozilla.org/integration/autoland/rev/556b6ba1f817
Enable Werror for SM(nu). r=sfink
https://hg.mozilla.org/integration/autoland/rev/06920e024491
Display compile commands for shell builds. r=RyanVM

Comment 20

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/405f930ae1b7
https://hg.mozilla.org/mozilla-central/rev/974fa9a5049d
https://hg.mozilla.org/mozilla-central/rev/556b6ba1f817
https://hg.mozilla.org/mozilla-central/rev/06920e024491

Comment 21

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/releases/mozilla-beta/rev/74020bf0bce0

Comment 22

[Ryan VanderMeulen (PTO, back July 27)]

That was just the SM(nu) patch to un-block another uplift.

Comment 23

[Ryan VanderMeulen (PTO, back July 27)]

Likewise for ESR52:
https://hg.mozilla.org/releases/mozilla-esr52/rev/df7ed78b7c0a