Closed
Bug 1342170
Opened 7 years ago
Closed 7 years ago
Fails to build with FILES_PER_UNIFIED_FILE = 1 set in js/src/moz.build
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: yury, Assigned: sfink)
References
Details
Attachments
(4 files, 2 obsolete files)
Latest m-c when build with FILES_PER_UNIFIED_FILE=1 (configure --disable-optimize --enable-debug --enable-warnings-as-errors) fails with following: In file included from /Users/yury/Work/mozilla-central/js/src/jit/BaselineCacheIRCompiler.cpp:7: In file included from /Users/yury/Work/mozilla-central/js/src/jit/BaselineCacheIRCompiler.h:11: In file included from /Users/yury/Work/mozilla-central/js/src/jit/CacheIR.h:16: In file included from /Users/yury/Work/mozilla-central/js/src/jit/SharedIC.h:11: /Users/yury/Work/mozilla-central/js/src/jscompartment.h:465:30: error: inline function 'JSCompartment::maybeGlobal' is not defined [-Werror,-Wundefined-inline] inline js::GlobalObject* maybeGlobal() const; ^ /Users/yury/Work/mozilla-central/js/src/jit/CacheIR.h:515:45: note: used here addStubField(uintptr_t(compartment->maybeGlobal()), StubField::Type::JSObject); ^ ---- In file included from /Users/yury/Work/mozilla-central/js/src/vm/ArgumentsObject.cpp:7: In file included from /Users/yury/Work/mozilla-central/js/src/vm/ArgumentsObject-inl.h:10: In file included from /Users/yury/Work/mozilla-central/js/src/vm/ArgumentsObject.h:13: /Users/yury/Work/mozilla-central/js/src/vm/NativeObject.h:481:5: error: inline function 'js::NativeObject::create' is not defined [-Werror,-Wundefined-inline] create(JSContext* cx, js::gc::AllocKind kind, js::gc::InitialHeap heap, ^ /Users/yury/Work/mozilla-central/js/src/vm/ArgumentsObject.cpp:232:55: note: used here JS_TRY_VAR_OR_RETURN_NULL(cx, base, NativeObject::create(cx, FINALIZE_KIND, gc::TenuredHeap, ^ First one regressed by bug 1319087 and second one by bug 1339411.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
Odd that SM(nu) didn't catch this in automation. Unless there's something platform/compiler specific going on here.
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8840533 [details] Bug 1342170 - Fixes jscompartment inlines for js/src/jit files. https://reviewboard.mozilla.org/r/115024/#review116494
Attachment #8840533 -
Flags: review?(evilpies) → review+
Reporter | ||
Updated•7 years ago
|
Summary: Enable to build with FILES_PER_UNIFIED_FILE = 1 set in js/src/moz.build → Fails to build with FILES_PER_UNIFIED_FILE = 1 set in js/src/moz.build
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8840551 [details] Bug 1342170 - Enable Werror for SM(nu). https://reviewboard.mozilla.org/r/115028/#review116518
Attachment #8840551 -
Flags: review?(sphink) → review+
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8840557 -
Flags: review?(ryanvm)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sphink
Status: NEW → ASSIGNED
Assignee | ||
Comment 8•7 years ago
|
||
Oops, got that backwards.
Attachment #8840558 -
Flags: review?(ryanvm)
Assignee | ||
Updated•7 years ago
|
Attachment #8840557 -
Attachment is obsolete: true
Attachment #8840557 -
Flags: review?(ryanvm)
Updated•7 years ago
|
Attachment #8840558 -
Flags: review?(ryanvm) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8840534 [details] Bug 1342170 - Fixes NativeObject::create inlines for js/src/vm/ files. https://reviewboard.mozilla.org/r/115026/#review116726 r=me with nit below addressed. ::: js/src/vm/ArgumentsObject.cpp:19 (Diff revision 2) > #include "vm/Stack.h" > > #include "jsobjinlines.h" > > #include "gc/Nursery-inl.h" > +#include "vm/NativeObject-inl.h" Nit: NativeObject should come before Nursery or the style checker will complain.
Attachment #8840534 -
Flags: review?(jdemooij) → review+
Comment 13•7 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #12) > Nit: NativeObject should come before Nursery or the style checker will > complain. Sorry my bad, it's gc/ vs vm/ so this is fine. Thanks for fixing!
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Reporter | ||
Updated•7 years ago
|
Attachment #8840558 -
Attachment is obsolete: true
Comment 18•7 years ago
|
||
mozreview-review |
Comment on attachment 8840958 [details] Bug 1342170 - Display compile commands for shell builds. https://reviewboard.mozilla.org/r/115334/#review116776
Attachment #8840958 -
Flags: review?(ryanvm) → review+
Comment 19•7 years ago
|
||
Pushed by ydelendik@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/405f930ae1b7 Fixes jscompartment inlines for js/src/jit files. r=evilpie https://hg.mozilla.org/integration/autoland/rev/974fa9a5049d Fixes NativeObject::create inlines for js/src/vm/ files. r=jandem https://hg.mozilla.org/integration/autoland/rev/556b6ba1f817 Enable Werror for SM(nu). r=sfink https://hg.mozilla.org/integration/autoland/rev/06920e024491 Display compile commands for shell builds. r=RyanVM
Comment 20•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/405f930ae1b7 https://hg.mozilla.org/mozilla-central/rev/974fa9a5049d https://hg.mozilla.org/mozilla-central/rev/556b6ba1f817 https://hg.mozilla.org/mozilla-central/rev/06920e024491
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Comment 21•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/74020bf0bce0
status-firefox53:
--- → fixed
Comment 22•7 years ago
|
||
That was just the SM(nu) patch to un-block another uplift.
status-firefox53:
fixed → ---
Comment 23•7 years ago
|
||
uplift |
Likewise for ESR52: https://hg.mozilla.org/releases/mozilla-esr52/rev/df7ed78b7c0a
You need to log in
before you can comment on or make changes to this bug.
Description
•