Closed
Bug 1342212
Opened 7 years ago
Closed 7 years ago
Include date of commit in cubeb README_MOZILLA
Categories
(Core :: Audio/Video: cubeb, defect)
Core
Audio/Video: cubeb
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
Details
(Whiteboard: [third-party-lib-audit])
Attachments
(1 file)
The Third Party Library Alert service needs the date of the commit used to be present to allow it to detect sufficiently old commits.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8840587 [details] Bug 1342212 Add the commit date to the cubeb README_MOZILLA file to allow automated tooling to detect too-old libraries https://reviewboard.mozilla.org/r/115046/#review116588 Thanks! This looks fine, but I'm clearing review pending an answer to my question. ::: media/libcubeb/update.sh:51 (Diff revision 1) > cp $1/test/test_utils.cpp gtest > cp $1/test/test_mixer.cpp gtest > > if [ -d $1/.git ]; then > rev=$(cd $1 && git rev-parse --verify HEAD) > + date=$(cd $1 && git show -s --format=%cI HEAD) Does it have to be this particular date format (%cI)? I ask because older (< v2.2) git versions don't have this (but do have the not-quite-ISO %ci). With an older git, this'll just print "%cI" instead of a date and fail to update README_MOZILLA. So if this date format is required, it'd be nice to fail older git versions in a nicer way.
Attachment #8840587 -
Flags: review?(kinetik)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8840587 [details] Bug 1342212 Add the commit date to the cubeb README_MOZILLA file to allow automated tooling to detect too-old libraries https://reviewboard.mozilla.org/r/115046/#review116588 > Does it have to be this particular date format (%cI)? I ask because older (< v2.2) git versions don't have this (but do have the not-quite-ISO %ci). > > With an older git, this'll just print "%cI" instead of a date and fail to update README_MOZILLA. So if this date format is required, it'd be nice to fail older git versions in a nicer way. It doesn't and fixed.
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8840587 [details] Bug 1342212 Add the commit date to the cubeb README_MOZILLA file to allow automated tooling to detect too-old libraries https://reviewboard.mozilla.org/r/115046/#review117034
Attachment #8840587 -
Flags: review?(kinetik) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment hidden (mozreview-request) |
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9a9362c9fcd9 Add the commit date to the cubeb README_MOZILLA file to allow automated tooling to detect too-old libraries. r=kinetik
Keywords: checkin-needed
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9a9362c9fcd9
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Assignee | ||
Updated•7 years ago
|
Whiteboard: [third-party-lib-audit]
You need to log in
before you can comment on or make changes to this bug.
Description
•