If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

stylo: Assertion failure: array->Count() == 2 (eCSSUnit_Calc_Plus should have a 2-length array), at nsCSSValue.cpp:873

RESOLVED FIXED in Firefox 55

Status

()

Core
CSS Parsing and Computation
P2
normal
RESOLVED FIXED
7 months ago
5 months ago

People

(Reporter: Tomcat, Assigned: hiro)

Tracking

(Blocks: 2 bugs, {assertion})

unspecified
mozilla55
assertion
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 unaffected, firefox-esr52 unaffected, firefox53 unaffected, firefox54 disabled, firefox55 fixed)

Details

(URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

(Reporter)

Description

7 months ago
Created attachment 8840748 [details]
bughunter stack

found via topsite bughunter tests on http://www.disqus.com and reproduced with latest stylo-debug build from taskcluster

Steps to reproduce:
-> Load http://www.disqus.com
---> Assertion failure after ~ 5 to 10 seconds on my fedora vm

Assertion failure: array->Count() == 2 (eCSSUnit_Calc_Plus should have a 2-length array), at /home/worker/workspace/build/src/layout/style/nsCSSValue.cpp:873
(Reporter)

Comment 1

7 months ago
note, this seem to happen on a lot of urls according to bughunter
status-firefox54: --- → affected
(Assignee)

Comment 2

7 months ago
This is animation bug.
Component: Layout → CSS Parsing and Computation
Summary: Assertion failure: array->Count() == 2 (eCSSUnit_Calc_Plus should have a 2-length array), at nsCSSValue.cpp:873 → [stylo] Assertion failure: array->Count() == 2 (eCSSUnit_Calc_Plus should have a 2-length array), at nsCSSValue.cpp:873
Blocks: 1343597
(Assignee)

Comment 3

7 months ago
Leaving ni to me.
Bug 1341985 or bug 1340322 fixes this.  I will check this again after those of bugs are closed.
Flags: needinfo?(hikezoe)
(Assignee)

Comment 4

7 months ago
Bug 1341985 fixed this.
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Flags: needinfo?(hikezoe)
Resolution: --- → FIXED
status-firefox53: --- → unaffected
status-firefox54: affected → disabled
status-firefox55: --- → fixed
status-firefox-esr52: --- → unaffected
status-firefox52: --- → unaffected
(Reporter)

Comment 5

5 months ago
seems this is not fixed, bughunter run into the same assertion again with todays build.

Its a stylo bug i guess because on win 7 i didn't crash but with the lastest stylo build from taskcluster i did.

Steps to reproduce:
Load http://www.wheelcovers.com 
wait for 10-30 seconds

--> Assertion failure: array->Count() == 2 (eCSSUnit_Calc_Plus should have a 2-length array), at /home/worker/workspace/build/src/layout/style/nsCSSValue.cpp:880
Status: RESOLVED → REOPENED
status-firefox55: fixed → affected
Flags: needinfo?(hikezoe)
Resolution: FIXED → ---
(Reporter)

Comment 6

5 months ago
Created attachment 8856840 [details]
new bughunter stack
Summary: [stylo] Assertion failure: array->Count() == 2 (eCSSUnit_Calc_Plus should have a 2-length array), at nsCSSValue.cpp:873 → stylo: Assertion failure: array->Count() == 2 (eCSSUnit_Calc_Plus should have a 2-length array), at nsCSSValue.cpp:873
No longer blocks: 1330412
Hiro, looks like this assertion failure was not fixed by bug 1341985 or bug 1340322.
Assignee: nobody → hikezoe
Priority: -- → P2
(Assignee)

Comment 8

5 months ago
I will look into this after I fixed bug 1354947.
(Assignee)

Comment 9

5 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=744f252d805441d018e10e5210e5351eea28662c
Flags: needinfo?(hikezoe)
(Assignee)

Comment 10

5 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e26ec592ae9ce4ebfc3223b6326a1836fa8c10b7
The commit of crash test in the previous try was empty!
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 13

5 months ago
mozreview-review
Comment on attachment 8862659 [details]
Bug 1342316 - Check eCSSUnit_Calc_Plus' array length in assertion.

https://reviewboard.mozilla.org/r/134524/#review137866
Attachment #8862659 - Flags: review?(cam) → review+

Comment 14

5 months ago
mozreview-review
Comment on attachment 8862660 [details]
Bug 1342316 - A crashtest which has calc() method in translate3d function as base style of transform animation.

https://reviewboard.mozilla.org/r/134526/#review137870
Attachment #8862660 - Flags: review?(cam) → review+

Comment 15

5 months ago
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2cf0ebc74751
Check eCSSUnit_Calc_Plus' array length in assertion. r=heycam
https://hg.mozilla.org/integration/autoland/rev/24032eef27b3
A crashtest which has calc() method in translate3d function as base style of transform animation. r=heycam
(Assignee)

Comment 16

5 months ago
Thank you!
https://hg.mozilla.org/mozilla-central/rev/2cf0ebc74751
https://hg.mozilla.org/mozilla-central/rev/24032eef27b3
Status: REOPENED → RESOLVED
Last Resolved: 7 months ago5 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.