1342316 - stylo: Assertion failure: array->Count() == 2 (eCSSUnit_Calc_Plus should have a 2-length array), at nsCSSValue.cpp:873

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Carsten Book [:Tomcat]]

Attachment: bughunter stack

found via topsite bughunter tests on http://www.disqus.com and reproduced with latest stylo-debug build from taskcluster

Steps to reproduce:
-> Load http://www.disqus.com
---> Assertion failure after ~ 5 to 10 seconds on my fedora vm

Assertion failure: array->Count() == 2 (eCSSUnit_Calc_Plus should have a 2-length array), at /home/worker/workspace/build/src/layout/style/nsCSSValue.cpp:873

Comment 1

[Carsten Book [:Tomcat]]

note, this seem to happen on a lot of urls according to bughunter

Comment 2

[Hiroyuki Ikezoe (:hiro)]

This is animation bug.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Leaving ni to me.
Bug 1341985 or bug 1340322 fixes this.  I will check this again after those of bugs are closed.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Bug 1341985 fixed this.

Comment 5

[Carsten Book [:Tomcat]]

seems this is not fixed, bughunter run into the same assertion again with todays build.

Its a stylo bug i guess because on win 7 i didn't crash but with the lastest stylo build from taskcluster i did.

Steps to reproduce:
Load http://www.wheelcovers.com 
wait for 10-30 seconds

--> Assertion failure: array->Count() == 2 (eCSSUnit_Calc_Plus should have a 2-length array), at /home/worker/workspace/build/src/layout/style/nsCSSValue.cpp:880

Comment 6

[Carsten Book [:Tomcat]]

Attachment: new bughunter stack

Comment 7

[Chris Peterson [:cpeterson]]

Hiro, looks like this assertion failure was not fixed by bug 1341985 or bug 1340322.

Comment 8

[Hiroyuki Ikezoe (:hiro)]

I will look into this after I fixed bug 1354947.

Comment 9

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=744f252d805441d018e10e5210e5351eea28662c

Comment 10

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e26ec592ae9ce4ebfc3223b6326a1836fa8c10b7
The commit of crash test in the previous try was empty!

Comment 11

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1342316 - Check eCSSUnit_Calc_Plus' array length in assertion.

Review commit: https://reviewboard.mozilla.org/r/134524/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134524/

Comment 12

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1342316 - A crashtest which has calc() method in translate3d function as base style of transform animation.

Review commit: https://reviewboard.mozilla.org/r/134526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134526/

Comment 13

[Cameron McCormack (:heycam)]

Comment on attachment 8862659 [details]
Bug 1342316 - Check eCSSUnit_Calc_Plus' array length in assertion.

https://reviewboard.mozilla.org/r/134524/#review137866

Comment 14

[Cameron McCormack (:heycam)]

Comment on attachment 8862660 [details]
Bug 1342316 - A crashtest which has calc() method in translate3d function as base style of transform animation.

https://reviewboard.mozilla.org/r/134526/#review137870

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cf0ebc74751
Check eCSSUnit_Calc_Plus' array length in assertion. r=heycam
https://hg.mozilla.org/integration/autoland/rev/24032eef27b3
A crashtest which has calc() method in translate3d function as base style of transform animation. r=heycam

Comment 16

[Hiroyuki Ikezoe (:hiro)]

Thank you!

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2cf0ebc74751
https://hg.mozilla.org/mozilla-central/rev/24032eef27b3

Comment 18

[nps1337]

あなたの経験を共有してくれてありがとう
https://www.vegus666.com/vegus168/

Comment 19

[Release mgmt bot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.