1342335 - Scrubber disappeared in animation view when timing properties are changed

Status: NEW

(DevTools :: Inspector: Animations, defect, P3)

Description

[Ankita Tanwar]

Attachment: Test Case

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce:

Test case

1. Open the attached test case
2. Open the DevTools panel with the animation inspector visible
3. Reload the test case
4. Observe how the scrubber disappears in the animations tab


Actual results:

Actual Result: Scrubber disappears


Expected results:

Expected Result: Scrubber should not disappear until the end of the graph.

Comment 1

[Ankita Tanwar]

Attachment: Recording Bug #1342335

Comment 2

[Patrick Brosset <:pbro>]

Thanks for filing this bug Ankita. Very clear steps, and the recording helps a lot too.
We'll triage this soon.

Comment 3

[Ankita Tanwar]

Hello Patrick,

I would like to work on this bug. Can you please provide some initial directions or files that I might have to look into.

Regards,
Ankita

Comment 4

[Patrick Brosset <:pbro>]

Thanks Ankita for also wanting to work on this bug. It seems similar to the other one you're working on already (bug 1330544), where the animation direction change is not getting noticed in the tool. Except that here, the duration change does cause a re-render, but the scrubber gets hidden for some reason.

I don't know where the bug comes from without investigating more fully, but I do know where you should start investigating: http://searchfox.org/mozilla-central/rev/4039fb4c5833706f6880763de216974e00ba096c/devtools/client/animationinspector/components/animation-timeline.js#380-391

This part of the code is what decides whether the scrubber should appear or not (and where), when the timeline is re-rendered.
So you might want to start debugging this code using the test case on this bug.

Comment 5

[Patrick Brosset <:pbro>]

Inspector bug triage (filter on CLIMBING SHOES).