Closed Bug 1342348 Opened 3 years ago Closed 3 years ago

In reader mode links are not underlined and blue colored

Categories

(Toolkit :: Reader Mode, defect)

54 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: roxana.leitan, Assigned: xidorn)

References

Details

Attachments

(2 files)

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170223030204

[Affected versions]:
Nightly 54.0a1

[Affected platforms]:
All platforms: Windows 10 x 64, Mac OS X 10.10

[Steps to reproduce]:
1.Launch Nightly 54.0a1 with a new profile
2.Go to: http://www.gutenberg.org/files/3300/3300-h/3300-h.htm or https://www.gnu.org/software/make/manual/make.html
3.Enter Reader mode

[Expected result]:
Links should be underlined and blue colored.

[Actual result]:
Links appear as normal text.

[Regression range]:
Last good revision: c7b015c488cfb2afbcff295a9639acd85df332f8
First bad revision: 47725823427b20c6229d0e1fa690972b90de7efe

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c7b015c488cfb2afbcff295a9639acd85df332f8&tochange=47725823427b20c6229d0e1fa690972b90de7efe

Most likely bug 1313278 is the culprit for this issue.
We're adding a test to test hash links on reader mode page in Bug 1340799. But the test cannot be passed for current m-c build because of the same issue mentioned in this bug.
Xidorn, I'm surprised this is breaking the way it is. Why are links being removed outright now? I expected the base to be removed, but not link hrefs... did you test this at all when writing the patch for bug 1313278?
Blocks: 1340799
Flags: needinfo?(xidorn+moz)
So this is because that, Reader mode passes in a fragment url with a context element in about:reader page, and thus the url fails security check inside nsTreeSanitizer::SanitizeURL because an about: page cannot be loaded from null principal.

It works previously because with xml:base specified in its ancestor, the base url of the element would be the original page.

The solution here, as far as I can see, is to explicitly allow urls with only fragment, since they cannot be harmful.

BTW, it seems that with xml:base removed in bug 1313278, the hacky fix added in bug 1280888 is no longer needed.
Flags: needinfo?(xidorn+moz)
Assignee: nobody → xidorn+moz
(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #3)
> So this is because that, Reader mode passes in a fragment url with a context
> element in about:reader page, and thus the url fails security check inside
> nsTreeSanitizer::SanitizeURL because an about: page cannot be loaded from
> null principal.

I'm confused - where does the null principal come from? We should be passing in a real base URI. It sounds like right now file:/// links in file:/// documents would also be breaking. Is that right?
Flags: needinfo?(xidorn+moz)
Comment on attachment 8841388 [details]
Bug 1342348 part 2 - Remove local link fix in about:reader.

https://reviewboard.mozilla.org/r/115610/#review117054

Assuming this passes the test in bug 1340799, r=me
Attachment #8841388 - Flags: review?(gijskruitbosch+bugs) → review+
I have no idea about the security check in nsTreeSanitizer::SanitizeURL. The base URI is used only for generating the absolute URI, so whether it presents doesn't affect the security check if the URI has been absolute.
Flags: needinfo?(xidorn+moz)
Comment on attachment 8841387 [details]
Bug 1342348 part 1 - Don't check fragment url in tree sanitizer.

https://reviewboard.mozilla.org/r/115608/#review117082
Attachment #8841387 - Flags: review?(hsivonen) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce9d71b0a088
part 1 - Don't check fragment url in tree sanitizer. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/d1578fd6f7e4
part 2 - Remove local link fix in about:reader. r=Gijs
Backed out for crashing in xpcshell test parser/xml/test/unit/test_sanitizer.js:

https://hg.mozilla.org/integration/autoland/rev/0edea4787f1b441247b20ab0ef180c85538cd750
https://hg.mozilla.org/integration/autoland/rev/e35c7e3eb3cc6ab342159612bd57ac194adf9b65

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d1578fd6f7e482744ad9c1a839cf922f5a58abcc&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=80370384&repo=autoland

[task 2017-02-27T14:18:08.567840Z] 14:18:08     INFO -  TEST-PASS | parser/xml/test/unit/test_sanitizer.js | run_test - [run_test : 19] "<html><head></head><body></body></html>" == "<html><head></head><body></body></html>"
[task 2017-02-27T14:18:08.569518Z] 14:18:08     INFO -  TEST-PASS | parser/xml/test/unit/test_sanitizer.js | run_test - [run_test : 19] "<html><head></head><body>\\n\\n</body></html>" == "<html><head></head><body>\\n\\n</body></html>"
[task 2017-02-27T14:18:08.570893Z] 14:18:08     INFO -  TEST-PASS | parser/xml/test/unit/test_sanitizer.js | run_test - [run_test : 19] "<html><head></head><body></body></html>" == "<html><head></head><body></body></html>"
[task 2017-02-27T14:18:08.571406Z] 14:18:08     INFO -  PROCESS | 12157 | ExceptionHandler::GenerateDump cloned child 12174
[task 2017-02-27T14:18:08.571762Z] 14:18:08     INFO -  PROCESS | 12157 | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2017-02-27T14:18:08.574540Z] 14:18:08     INFO -  PROCESS | 12157 | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2017-02-27T14:18:08.574890Z] 14:18:08     INFO -  <<<<<<<
[task 2017-02-27T14:18:08.576235Z] 14:18:08     INFO -  mozcrash Downloading symbols from: https://queue.taskcluster.net/v1/task/LXgds1jqSUOVAqwXUx__og/artifacts/public/build/target.crashreporter-symbols.zip
[task 2017-02-27T14:18:22.147667Z] 14:18:22     INFO -  mozcrash Copy/paste: /usr/local/bin/linux64-minidump_stackwalk /tmp/xpc-other-wizohZ/338c6624-17ff-ca30-2b759cde-1d45a0ee.dmp /tmp/tmpLWWNco
[task 2017-02-27T14:18:37.325407Z] 14:18:37     INFO -  mozcrash Saved minidump as /home/worker/workspace/build/blobber_upload_dir/338c6624-17ff-ca30-2b759cde-1d45a0ee.dmp
[task 2017-02-27T14:18:37.329069Z] 14:18:37     INFO -  mozcrash Saved app info as /home/worker/workspace/build/blobber_upload_dir/338c6624-17ff-ca30-2b759cde-1d45a0ee.extra
[task 2017-02-27T14:18:37.343349Z] 14:18:37  WARNING -  PROCESS-CRASH | parser/xml/test/unit/test_sanitizer.js | application crashed [@ nsAString_internal::First]
[task 2017-02-27T14:18:37.343770Z] 14:18:37     INFO -  Crash dump filename: /tmp/xpc-other-wizohZ/338c6624-17ff-ca30-2b759cde-1d45a0ee.dmp
[task 2017-02-27T14:18:37.345255Z] 14:18:37     INFO -  Operating system: Linux
[task 2017-02-27T14:18:37.346570Z] 14:18:37     INFO -                    0.0.0 Linux 3.13.0-100-generic #147-Ubuntu SMP Tue Oct 18 16:48:51 UTC 2016 x86_64
[task 2017-02-27T14:18:37.346883Z] 14:18:37     INFO -  CPU: x86
[task 2017-02-27T14:18:37.347142Z] 14:18:37     INFO -       GenuineIntel family 6 model 62 stepping 4
[task 2017-02-27T14:18:37.348505Z] 14:18:37     INFO -       1 CPU
[task 2017-02-27T14:18:37.349829Z] 14:18:37     INFO -  GPU: UNKNOWN
[task 2017-02-27T14:18:37.351705Z] 14:18:37     INFO -  Crash reason:  SIGSEGV
[task 2017-02-27T14:18:37.356170Z] 14:18:37     INFO -  Crash address: 0x0
[task 2017-02-27T14:18:37.357977Z] 14:18:37     INFO -  Process uptime: not available
[task 2017-02-27T14:18:37.359606Z] 14:18:37     INFO -  Thread 0 (crashed)
[task 2017-02-27T14:18:37.361492Z] 14:18:37     INFO -   0  libxul.so!nsAString_internal::First [nsTSubstring.cpp:d1578fd6f7e4 : 41 + 0x0]
[task 2017-02-27T14:18:37.363246Z] 14:18:37     INFO -      eip = 0xf3c7e861   esp = 0xffc34118   ebp = 0xffc34118   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.365101Z] 14:18:37     INFO -      esi = 0xeef544c0   edi = 0xeb4840e0   eax = 0x08066860   ecx = 0xf7670fb0
[task 2017-02-27T14:18:37.366936Z] 14:18:37     INFO -      edx = 0xf64146d8   efl = 0x00010246
[task 2017-02-27T14:18:37.371445Z] 14:18:37     INFO -      Found by: given as instruction pointer in context
[task 2017-02-27T14:18:37.373392Z] 14:18:37     INFO -   1  libxul.so!nsTreeSanitizer::SanitizeURL [nsTreeSanitizer.cpp:d1578fd6f7e4 : 1285 + 0xb]
[task 2017-02-27T14:18:37.375266Z] 14:18:37     INFO -      eip = 0xf4635f0f   esp = 0xffc34120   ebp = 0xffc34208   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.377025Z] 14:18:37     INFO -      esi = 0xeef544c0   edi = 0xeb4840e0
[task 2017-02-27T14:18:37.378747Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.380545Z] 14:18:37     INFO -   2  libxul.so!nsTreeSanitizer::SanitizeAttributes [nsTreeSanitizer.cpp:d1578fd6f7e4 : 1187 + 0xc]
[task 2017-02-27T14:18:37.383366Z] 14:18:37     INFO -      eip = 0xf4644550   esp = 0xffc34210   ebp = 0xffc34398   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.385185Z] 14:18:37     INFO -      esi = 0xeef544c0   edi = 0xeb4840e0
[task 2017-02-27T14:18:37.386961Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.389037Z] 14:18:37     INFO -   3  libxul.so!nsTreeSanitizer::SanitizeChildren [nsTreeSanitizer.cpp:d1578fd6f7e4 : 1460 + 0x1c]
[task 2017-02-27T14:18:37.391474Z] 14:18:37     INFO -      eip = 0xf46449d6   esp = 0xffc343a0   ebp = 0xffc34528   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.393420Z] 14:18:37     INFO -      esi = 0xeb4840e0   edi = 0x00000003
[task 2017-02-27T14:18:37.395479Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.397595Z] 14:18:37     INFO -   4  libxul.so!nsParserUtils::Sanitize [nsParserUtils.cpp:d1578fd6f7e4 : 98 + 0xb]
[task 2017-02-27T14:18:37.403596Z] 14:18:37     INFO -      eip = 0xf43011c1   esp = 0xffc34530   ebp = 0xffc345b8   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.405444Z] 14:18:37     INFO -      esi = 0x00000000   edi = 0xffc3456c
[task 2017-02-27T14:18:37.407208Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.408940Z] 14:18:37     INFO -   5  libxul.so!NS_InvokeByIndex + 0x30
[task 2017-02-27T14:18:37.410702Z] 14:18:37     INFO -      eip = 0xf3cde036   esp = 0xffc345c0   ebp = 0xffc345e8   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.412418Z] 14:18:37     INFO -      esi = 0xffc346f0   edi = 0x00000003
[task 2017-02-27T14:18:37.414149Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.415943Z] 14:18:37     INFO -   6  libxul.so!XPCWrappedNative::CallMethod [XPCWrappedNative.cpp:d1578fd6f7e4 : 2010 + 0x16]
[task 2017-02-27T14:18:37.417842Z] 14:18:37     INFO -      eip = 0xf423939b   esp = 0xffc345f0   ebp = 0xffc34778
[task 2017-02-27T14:18:37.419910Z] 14:18:37     INFO -      Found by: previous frame's frame pointer
[task 2017-02-27T14:18:37.423394Z] 14:18:37     INFO -   7  libxul.so!XPC_WN_CallMethod [XPCWrappedNativeJSOps.cpp:d1578fd6f7e4 : 983 + 0xa]
[task 2017-02-27T14:18:37.425253Z] 14:18:37     INFO -      eip = 0xf423fd03   esp = 0xffc34780   ebp = 0xffc34848   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.427399Z] 14:18:37     INFO -      esi = 0xffc347dc   edi = 0xffc347bc
[task 2017-02-27T14:18:37.429339Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.431490Z] 14:18:37     INFO -   8  0x4f62c180
[task 2017-02-27T14:18:37.435368Z] 14:18:37     INFO -      eip = 0x4f62c180   esp = 0xffc34850   ebp = 0xffc34898   ebx = 0xedbc2610
[task 2017-02-27T14:18:37.437403Z] 14:18:37     INFO -      esi = 0xedb72660   edi = 0xec7cb6c0
[task 2017-02-27T14:18:37.439900Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.443468Z] 14:18:37     INFO -   9  0xec7cb6c0
[task 2017-02-27T14:18:37.445292Z] 14:18:37     INFO -      eip = 0xec7cb6c0   esp = 0xffc348a0   ebp = 0xffc3493c
[task 2017-02-27T14:18:37.447045Z] 14:18:37     INFO -      Found by: previous frame's frame pointer
[task 2017-02-27T14:18:37.448689Z] 14:18:37     INFO -  10  0x4f60b922
[task 2017-02-27T14:18:37.450774Z] 14:18:37     INFO -      eip = 0x4f60b922   esp = 0xffc34944   ebp = 0xffc34968
[task 2017-02-27T14:18:37.452841Z] 14:18:37     INFO -      Found by: previous frame's frame pointer
[task 2017-02-27T14:18:37.454924Z] 14:18:37     INFO -  11  libxul.so!EnterBaseline [BaselineJIT.cpp:d1578fd6f7e4 : 162 + 0x34]
[task 2017-02-27T14:18:37.459504Z] 14:18:37     INFO -      eip = 0xf5d496d2   esp = 0xffc34970   ebp = 0xffc34a48
[task 2017-02-27T14:18:37.461320Z] 14:18:37     INFO -      Found by: previous frame's frame pointer
[task 2017-02-27T14:18:37.463173Z] 14:18:37     INFO -  12  libxul.so!js::jit::EnterBaselineAtBranch [BaselineJIT.cpp:d1578fd6f7e4 : 268 + 0xd]
[task 2017-02-27T14:18:37.465050Z] 14:18:37     INFO -      eip = 0xf5d6c4ad   esp = 0xffc34a50   ebp = 0xffc34b88   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.466733Z] 14:18:37     INFO -      esi = 0xf2307800   edi = 0xed97e118
[task 2017-02-27T14:18:37.468556Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.470514Z] 14:18:37     INFO -  13  libxul.so!Interpret [Interpreter.cpp:d1578fd6f7e4 : 1911 + 0x16]
[task 2017-02-27T14:18:37.472639Z] 14:18:37     INFO -      eip = 0xf5cc8f5f   esp = 0xffc34b90   ebp = 0xffc34f08   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.474728Z] 14:18:37     INFO -      esi = 0xf2307800   edi = 0xffc34e68
[task 2017-02-27T14:18:37.476805Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.479520Z] 14:18:37     INFO -  14  libxul.so!js::RunScript [Interpreter.cpp:d1578fd6f7e4 : 394 + 0xa]
[task 2017-02-27T14:18:37.481382Z] 14:18:37     INFO -      eip = 0xf5ccb755   esp = 0xffc34f10   ebp = 0xffc34f98   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.487333Z] 14:18:37     INFO -      esi = 0xf2307800   edi = 0xffc34f50
[task 2017-02-27T14:18:37.489145Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.490935Z] 14:18:37     INFO -  15  libxul.so!js::InternalCallOrConstruct [Interpreter.cpp:d1578fd6f7e4 : 466 + 0xf]
[task 2017-02-27T14:18:37.492742Z] 14:18:37     INFO -      eip = 0xf5ccbd58   esp = 0xffc34fa0   ebp = 0xffc35038   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.494463Z] 14:18:37     INFO -      esi = 0xffc34ffc   edi = 0xf2307800
[task 2017-02-27T14:18:37.496171Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.497978Z] 14:18:37     INFO -  16  libxul.so!InternalCall [Interpreter.cpp:d1578fd6f7e4 : 493 + 0x15]
[task 2017-02-27T14:18:37.499770Z] 14:18:37     INFO -      eip = 0xf5ccc0da   esp = 0xffc35040   ebp = 0xffc35078   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.501473Z] 14:18:37     INFO -      esi = 0xeda3d31e   edi = 0xf2307800
[task 2017-02-27T14:18:37.503213Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.505178Z] 14:18:37     INFO -  17  libxul.so!js::jit::DoCallFallback [BaselineIC.cpp:d1578fd6f7e4 : 2340 + 0x18]
[task 2017-02-27T14:18:37.507532Z] 14:18:37     INFO -      eip = 0xf5d7005a   esp = 0xffc35080   ebp = 0xffc351f8   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.511346Z] 14:18:37     INFO -      esi = 0xeda3d31e   edi = 0xf2307800
[task 2017-02-27T14:18:37.513154Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.514813Z] 14:18:37     INFO -  18  0x4f611fd4
[task 2017-02-27T14:18:37.516617Z] 14:18:37     INFO -      eip = 0x4f611fd4   esp = 0xffc35200   ebp = 0xffc35258   ebx = 0xffc35220
[task 2017-02-27T14:18:37.518360Z] 14:18:37     INFO -      esi = 0x4f618587   edi = 0xec75bd38
[task 2017-02-27T14:18:37.523302Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.525108Z] 14:18:37     INFO -  19  0xec75bd38
[task 2017-02-27T14:18:37.526932Z] 14:18:37     INFO -      eip = 0xec75bd38   esp = 0xffc35260   ebp = 0xffc352cc
[task 2017-02-27T14:18:37.528730Z] 14:18:37     INFO -      Found by: previous frame's frame pointer
[task 2017-02-27T14:18:37.530366Z] 14:18:37     INFO -  20  0x4f60b922
[task 2017-02-27T14:18:37.532251Z] 14:18:37     INFO -      eip = 0x4f60b922   esp = 0xffc352d4   ebp = 0xffc352f8
[task 2017-02-27T14:18:37.534083Z] 14:18:37     INFO -      Found by: previous frame's frame pointer
[task 2017-02-27T14:18:37.535900Z] 14:18:37     INFO -  21  libxul.so!EnterBaseline [BaselineJIT.cpp:d1578fd6f7e4 : 162 + 0x34]
[task 2017-02-27T14:18:37.537922Z] 14:18:37     INFO -      eip = 0xf5d496d2   esp = 0xffc35300   ebp = 0xffc353d8
[task 2017-02-27T14:18:37.543371Z] 14:18:37     INFO -      Found by: previous frame's frame pointer
[task 2017-02-27T14:18:37.552038Z] 14:18:37     INFO -  22  libxul.so!js::jit::EnterBaselineAtBranch [BaselineJIT.cpp:d1578fd6f7e4 : 268 + 0xd]
[task 2017-02-27T14:18:37.554088Z] 14:18:37     INFO -      eip = 0xf5d6c4ad   esp = 0xffc353e0   ebp = 0xffc35518   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.555857Z] 14:18:37     INFO -      esi = 0xf2307800   edi = 0xed97e070
[task 2017-02-27T14:18:37.559985Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.561766Z] 14:18:37     INFO -  23  libxul.so!Interpret [Interpreter.cpp:d1578fd6f7e4 : 1911 + 0x16]
[task 2017-02-27T14:18:37.563546Z] 14:18:37     INFO -      eip = 0xf5cc8f5f   esp = 0xffc35520   ebp = 0xffc35898   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.568011Z] 14:18:37     INFO -      esi = 0xf2307800   edi = 0xffc357f8
[task 2017-02-27T14:18:37.569782Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.571828Z] 14:18:37     INFO -  24  libxul.so!js::RunScript [Interpreter.cpp:d1578fd6f7e4 : 394 + 0xa]
[task 2017-02-27T14:18:37.583547Z] 14:18:37     INFO -      eip = 0xf5ccb755   esp = 0xffc358a0   ebp = 0xffc35928   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.585387Z] 14:18:37     INFO -      esi = 0xf2307800   edi = 0xffc358e0
[task 2017-02-27T14:18:37.587090Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.592351Z] 14:18:37     INFO -  25  libxul.so!js::Execute [Interpreter.cpp:d1578fd6f7e4 : 677 + 0xc]
[task 2017-02-27T14:18:37.594587Z] 14:18:37     INFO -      eip = 0xf5ccd746   esp = 0xffc35930   ebp = 0xffc359b8   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.598277Z] 14:18:37     INFO -      esi = 0xf2307800   edi = 0xffc35be0
[task 2017-02-27T14:18:37.604604Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.606652Z] 14:18:37     INFO -  26  libxul.so!Evaluate [jsapi.cpp:d1578fd6f7e4 : 4563 + 0x16]
[task 2017-02-27T14:18:37.608764Z] 14:18:37     INFO -      eip = 0xf5fbb76d   esp = 0xffc359c0   ebp = 0xffc35aa8   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.610792Z] 14:18:37     INFO -      esi = 0xf2307800   edi = 0xffc35a08
[task 2017-02-27T14:18:37.613081Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.615519Z] 14:18:37     INFO -  27  libxul.so!JS::Evaluate [jsapi.cpp:d1578fd6f7e4 : 4615 + 0x1b]
[task 2017-02-27T14:18:37.619363Z] 14:18:37     INFO -      eip = 0xf5fbc3f2   esp = 0xffc35ab0   ebp = 0xffc35b18   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.621128Z] 14:18:37     INFO -      esi = 0xf2307800   edi = 0xffc35ca4
[task 2017-02-27T14:18:37.622775Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.624627Z] 14:18:37     INFO -  28  libxul.so!XRE_XPCShellMain [XPCShellImpl.cpp:d1578fd6f7e4 : 1139 + 0x2d]
[task 2017-02-27T14:18:37.626365Z] 14:18:37     INFO -      eip = 0xf4229fcc   esp = 0xffc35b20   ebp = 0xffc35db8   ebx = 0xf7670fb0
[task 2017-02-27T14:18:37.631313Z] 14:18:37     INFO -      esi = 0x00000017   edi = 0xffc367bb
[task 2017-02-27T14:18:37.633128Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.634906Z] 14:18:37     INFO -  29  xpcshell!main [xpcshell.cpp:d1578fd6f7e4 : 68 + 0x13]
[task 2017-02-27T14:18:37.636696Z] 14:18:37     INFO -      eip = 0x0804c0df   esp = 0xffc35dc0   ebp = 0xffc35e18   ebx = 0x0806622c
[task 2017-02-27T14:18:37.638463Z] 14:18:37     INFO -      esi = 0xffc35e30   edi = 0xf23270c0
[task 2017-02-27T14:18:37.640210Z] 14:18:37     INFO -      Found by: call frame info
[task 2017-02-27T14:18:37.641908Z] 14:18:37     INFO -  30  libc-2.15.so + 0x19533
[task 2017-02-27T14:18:37.643800Z] 14:18:37     INFO -      eip = 0xf2cb0533   esp = 0xffc35e20   ebp = 0x00000000
[task 2017-02-27T14:18:37.645771Z] 14:18:37     INFO -      Found by: previous frame's frame pointer
[task 2017-02-27T14:18:37.647768Z] 14:18:37     INFO -  31  xpcshell!__libc_csu_fini + 0x10
[task 2017-02-27T14:18:37.649786Z] 14:18:37     INFO -      eip = 0x08060380   esp = 0xffc35e24   ebp = 0x00000000
[task 2017-02-27T14:18:37.651802Z] 14:18:37     INFO -      Found by: stack scanning
[task 2017-02-27T14:18:37.655486Z] 14:18:37     INFO -  32  libc-2.15.so + 0x19533
[task 2017-02-27T14:18:37.657234Z] 14:18:37     INFO -      eip = 0xf2cb0533   esp = 0xffc35e30   ebp = 0x00000000
[task 2017-02-27T14:18:37.658958Z] 14:18:37     INFO -      Found by: stack scanning
[task 2017-02-27T14:18:37.660640Z] 14:18:37     INFO -  33  libc-2.15.so + 0x1a4ff4
[task 2017-02-27T14:18:37.662493Z] 14:18:37     INFO -      eip = 0xf2e3bff4   esp = 0xffc35e58   ebp = 0x00000000
[task 2017-02-27T14:18:37.667343Z] 14:18:37     INFO -      Found by: stack scanning
[task 2017-02-27T14:18:37.669082Z] 14:18:37     INFO -  34  xpcshell + 0x42f8
[task 2017-02-27T14:18:37.670815Z] 14:18:37     INFO -      eip = 0x0804c2f8   esp = 0xffc35e80   ebp = 0x00000000
[task 2017-02-27T14:18:37.672582Z] 14:18:37     INFO -      Found by: stack scanning
[task 2017-02-27T14:18:37.674223Z] 14:18:37     INFO -  35  ld-2.15.so + 0x14660
[task 2017-02-27T14:18:37.676001Z] 14:18:37     INFO -      eip = 0xf7770660   esp = 0xffc35e88   ebp = 0x00000000
[task 2017-02-27T14:18:37.677640Z] 14:18:37     INFO -      Found by: stack scanning
[task 2017-02-27T14:18:37.679338Z] 14:18:37     INFO -  36  libc-2.15.so + 0x19449
[task 2017-02-27T14:18:37.683373Z] 14:18:37     INFO -      eip = 0xf2cb0449   esp = 0xffc35e8c   ebp = 0x00000000
[task 2017-02-27T14:18:37.685123Z] 14:18:37     INFO -      Found by: stack scanning
[task 2017-02-27T14:18:37.686805Z] 14:18:37     INFO -  37  ld-2.15.so + 0x20ff4
[task 2017-02-27T14:18:37.688608Z] 14:18:37     INFO -      eip = 0xf777cff4   esp = 0xffc35e90   ebp = 0x00000000
[task 2017-02-27T14:18:37.690307Z] 14:18:37     INFO -      Found by: stack scanning
[task 2017-02-27T14:18:37.692112Z] 14:18:37     INFO -  38  xpcshell + 0x42f8
[task 2017-02-27T14:18:37.695355Z] 14:18:37     INFO -      eip = 0x0804c2f8   esp = 0xffc35e98   ebp = 0x00000000
[task 2017-02-27T14:18:37.697111Z] 14:18:37     INFO -      Found by: stack scanning
[task 2017-02-27T14:18:37.698720Z] 14:18:37     INFO -  39  xpcshell!_start + 0x21
[task 2017-02-27T14:18:37.700575Z] 14:18:37     INFO -      eip = 0x0804c319   esp = 0xffc35ea0   ebp = 0x00000000
[task 2017-02-27T14:18:37.703769Z] 14:18:37     INFO -      Found by: stack scanning
[task 2017-02-27T14:18:37.707325Z] 14:18:37     INFO -  40  xpcshell + 0x406c
[task 2017-02-27T14:18:37.709088Z] 14:18:37     INFO -      eip = 0x0804c06c   esp = 0xffc35ea4   ebp = 0x00000000
[task 2017-02-27T14:18:37.710792Z] 14:18:37     INFO -      Found by: stack scanning
[task 2017-02-27T14:18:37.712499Z] 14:18:37     INFO -  41  xpcshell!__libc_csu_fini + 0x10
[task 2017-02-27T14:18:37.714359Z] 14:18:37     INFO -      eip = 0x08060380   esp = 0xffc35eb0   ebp = 0xffc35ec4
[task 2017-02-27T14:18:37.716314Z] 14:18:37     INFO -      Found by: stack scanning
[task 2017-02-27T14:18:37.718186Z] 14:18:37     INFO -  42  0xffc3649c
[task 2017-02-27T14:18:37.720238Z] 14:18:37     INFO -      eip = 0xffc3649c   esp = 0xffc35ecc   ebp = 0xffc36462
[task 2017-02-27T14:18:37.723638Z] 14:18:37     INFO -      Found by: previous frame's frame pointer
[task 2017-02-27T14:18:37.725327Z] 14:18:37     INFO -  43  0x6f772f65
[task 2017-02-27T14:18:37.731335Z] 14:18:37     INFO -      eip = 0x6f772f65   esp = 0xffc3646a   ebp = 0x6d6f682f
[task 2017-02-27T14:18:37.733178Z] 14:18:37     INFO -      Found by: previous frame's frame pointer
Flags: needinfo?(xidorn+moz)
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4f0fce98dd3a
part 1 - Don't check fragment url in tree sanitizer. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/6e181ffefa61
part 2 - Remove local link fix in about:reader. r=Gijs
Flags: needinfo?(xidorn+moz)
I must be drunk... although I didn't drink any alcohol...
Flags: needinfo?(xidorn+moz)
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/661208405ab2
part 1 - Don't check fragment url in tree sanitizer. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/8894970bdee6
part 2 - Remove local link fix in about:reader. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/661208405ab2
https://hg.mozilla.org/mozilla-central/rev/8894970bdee6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.