1342354 - Add pref on/off switch for new bookmark features

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Nevin Chen(Not active on Bugzilla)]

We need a new pref in about:config for disable new bookmark features before development completed.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1342354 - Add pref pref on/off switch for new bookmark features.

Review commit: https://reviewboard.mozilla.org/r/115632/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115632/

Comment 2

[Andrzej Hunt :ahunt]

Comment on attachment 8841409 [details]
Bug 1342354 - Add pref pref on/off switch for new bookmark features.

https://reviewboard.mozilla.org/r/115632/#review117152

::: mobile/android/base/java/org/mozilla/gecko/home/BookmarksPanel.java:132
(Diff revision 1)
>          });
>  
>          return view;
>      }
>  
> +    private void getGeckoPreference() {

Maybe name this something like setupPrefHandler() or similar to make it more obvious?

Comment 3

[Carsten Book [:Tomcat]]

seems there is a open issue in mozreview, this need to be fixed before we can autoland this patch. Could you take a look, thanks!

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Fixed. Thanks!

Comment 5

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8841409 [details]
Bug 1342354 - Add pref pref on/off switch for new bookmark features.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115632/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b8279c5d55d
Add pref pref on/off switch for new bookmark features. r=ahunt

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0b8279c5d55d