1342372 - Crash in memcpy | pkcs11_copyStaticData

Status: RESOLVED FIXED

(NSS :: Libraries, defect, critical)

Description

[[:philipp]]

This bug was filed from the Socorro interface and is 
report bp-41088f40-1ca5-4352-a5d7-469692170224.
=============================================================
Crashing Thread (58)
Frame 	Module 	Signature 	Source
0 	vcruntime140.dll 	memcpy 	f:\dd\vctools\crt\vcruntime\src\string\i386\memcpy.asm:194
1 	nssdbm3.dll 	pkcs11_copyStaticData 	security/nss/lib/softoken/legacydb/pcertdb.c:372
2 	nssdbm3.dll 	DecodeDBCertEntry 	security/nss/lib/softoken/legacydb/pcertdb.c:737
3 	nssdbm3.dll 	ReadDBCertEntry 	security/nss/lib/softoken/legacydb/pcertdb.c:1071
4 	nssdbm3.dll 	nsslowcert_FindCertByKey 	security/nss/lib/softoken/legacydb/pcertdb.c:4695
5 	nssdbm3.dll 	lg_getCert 	security/nss/lib/softoken/legacydb/lgattr.c:312
6 	nssdbm3.dll 	lg_FindCertAttribute 	security/nss/lib/softoken/legacydb/lgattr.c:1267
7 	nssdbm3.dll 	lg_DBUnlock 	security/nss/lib/softoken/legacydb/lginit.c:424
8 	nssdbm3.dll 	lg_GetSingleAttribute 	security/nss/lib/softoken/legacydb/lgattr.c:1341
9 	nssdbm3.dll 	lg_GetAttributeValue 	security/nss/lib/softoken/legacydb/lgattr.c:1376
10 	softokn3.dll 	sftkdb_GetAttributeValue 	security/nss/lib/softoken/sftkdb.c:1322
11 	softokn3.dll 	NSC_GetAttributeValue 	security/nss/lib/softoken/pkcs11.c:4444
12 	nss3.dll 	nssCKObject_GetAttributes 	security/nss/lib/dev/ckhelper.c:83
13 	nss3.dll 	nssCryptokiObject_Create 	security/nss/lib/dev/devutil.c:28
14 	nss3.dll 	import_object 	security/nss/lib/dev/devtoken.c:202
15 	nss3.dll 	nssToken_ImportCertificate 	security/nss/lib/dev/devtoken.c:539
16 		@0x91b30af

this crash signature in 32bit builds on all versions of windows started occurring frequently on 2016-12-09.

Comment 1

[Gerry Chang [:gchang]]

We don't have the plan to have dot release for 51. Mark 51 won't fix.

Comment 2

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

This is probably an NSS issue.

Comment 3

[Franziskus Kiefer [:franziskus]]

Firefox really has to stop using the legacydb :(
https://nss-review.dev.mozaws.net/D269

Comment 4

[Franziskus Kiefer [:franziskus]]

I don't know if this will fix the problem. But it's my best guess.

https://hg.mozilla.org/projects/nss/rev/ae115cf470409ca6f01482c98e93b427974538b1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Hard to say if this helped or not since we don't have any reports from anything newer than 52 in the last 3 months :(

Comment 6

[Franziskus Kiefer [:franziskus]]

Hm, but there won't be another 52 release, so I guess we have to wait and see. But if there are no crashes on newer versions, I'd hope the problem was solved (not by this patch though).
I can only repeat myself: FF has to stop using this code :(

Comment 7

[Ryan VanderMeulen [:RyanVM]]

There's still a handful of crashes on ESR52, but it's low-volume and it seems like any fix we'd consider landing would be speculative at best. Doesn't seem worth tracking at this point.