1342444 - Mock - Default HeartBeat Survey is not shown 7 days later

Status: RESOLVED WORKSFORME

(Shield :: General, defect)

Description

[ovidiu boca[:Ovidiu]]

[Affected versions]:

Firefox Nighlty 54.0a1(2017-02-23), Firefox Aurora 53.0a2(2017-02-23)

[Affected platforms]:

Mac OS X 10.10, Ubuntu 16.04, Win 10


[Steps to reproduce]:


Preconditions:

1. Obtain a copy of Firefox with the SHIELD recipe client system add-on installed. You can check about:support to ensure that you have it.
2. Set the extensions.shield-recipe-client.dev_mode preference to true to run recipes immediately on startup.
3. Set the extensions.shield-recipe-client.logging.level preference to 0 to enable more logging.
4. Set the security.content.signature.root_hash preference to 4C:35:B1:C3:E3:12:D9:55:E7:78:ED:D0:A7:E7:8A:38:83:04:EF:01:BF:FA:03:29:B2:46:9F:3C:C5:EC:36:04. This is the public hash used for verifying content signatures of the test data


Steps:

1 Open Firefox and Open about:config and set 
extensions.shield-recipe-client.api_url
to
https://normandy-mock.dev.mozaws.net/ShowHeartbeatButton/api/v1
2. Restart FF browser
3. A heartbeat Survey is shown.
4. Close firefox
5. Reopen Firefox -> Recipe is not executed again, the survey is not shown
6. Close Firefox and Modify system date and add 8 days to system time
7. Open Firefox


[Expected result]:

The survey is shown.


[Actual result]:

The survey doesn't appear.

Comment 1

[ovidiu boca[:Ovidiu]]

I also tried to modify shield-recipe-client.json and rewinding the date with 8-10 days but the heartbeat wasn't triggered.

Comment 2

[Osmose [:osmose, :mkelly]]

So from what I can tell, when we added repeat options for Heartbeat dialogs, we didn't update the mock-server testcases, so the mock-server recipes default to the "show once and never again" behavior, which matches the behavior you saw.

I think the bug here is to update the mock-server test cases to cover the three different repeat options. Once that's up, we can re-test and verify if they're behaving as expected. Does that sound good?

Comment 3

[ovidiu boca[:Ovidiu]]

That is a great idea, I will make sure to cover all the options from the drop down. Please announce me when that's up. Thanks

Comment 4

[ovidiu boca[:Ovidiu]]

Mike, just to make this clear, when you say "three different repeat options" on what recipes do you refer? 
Sorry for this but I want to make sure that I understand correctly. Thanks

Comment 5

[ovidiu boca[:Ovidiu]]

I figured out what I wanted to ask you. I will create 3 test cases that will cover all the scenarios. Sorry for the spam.

Comment 6

[Osmose [:osmose, :mkelly]]

Ovidiu: We still haven't gotten around to updating the mock server testcases, did you test this against the staging server? If the feature is working, we should reword or close this bug since functionally it's working as expected, I think.

Comment 7

[ovidiu boca[:Ovidiu]]

We tested with a new profile on beta version FF 53.0b9 and everything works as expected. We also run a test with an old profile and on Nightly FF 55.0a1(2017-04-05) it worked but on beta with the same profile it didn't. We'll investigate this situation until then I will leave my NI? flag.

Comment 8

[ovidiu boca[:Ovidiu]]

We figured out what was the problem, on the older profile the shield wasn't installed on Beta only on Nightly. 
I will mark this as resolved WFM based on comment 7.