Closed Bug 1342493 Opened 7 years ago Closed 7 years ago

stylo: need to fix length parsing in servo

Categories

(Core :: CSS Parsing and Computation, defect, P2)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox54 --- affected

People

(Reporter: bzbarsky, Unassigned)

References

Details

(Whiteboard: [Stylo:servo]) 

Servo's length parsing is broken in two ways:

1)  Does a lossy conversion to twips at parse time.
2)  Does the conversion by floor, not round.

So if you feed in a value like "4pt" and then get the computed value, you get "5.33333px", which is fine.  But if you feed _that_ in you get back "5.31667px" as the computed value.

https://github.com/servo/servo/issues/15729 tracks.
Priority: -- → P2
Whiteboard: [Stylo:servo]
A contributor has a PR for this: https://github.com/servo/servo/pull/16229
Since the PR has been merged, and the test expectations have been updated in https://hg.mozilla.org/integration/autoland/rev/970eb52865f5, I think we can resolve this bug. :)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.