Closed
Bug 1342497
Opened 7 years ago
Closed 7 years ago
Baldr: store current frame, not previous frame, in wasm::FrameIterator
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: luke, Assigned: luke)
Details
Attachments
(1 file)
5.53 KB,
patch
|
yury
:
review+
|
Details | Diff | Splinter Review |
This patch changes the internal fp_ of wasm::FrameIterator to point to the current frame, not the previous frame. This is both a nice simplification and also avoids a corner case where the frame that gets stored in a Debugger.Frame can become stale. I hit this with patches in bug 1334504, but wanted to get this in before that bug since I expect it might happen in other cases.
Attachment #8840999 -
Flags: review?(ydelendik)
Comment 1•7 years ago
|
||
Comment on attachment 8840999 [details] [diff] [review] change-iter Review of attachment 8840999 [details] [diff] [review]: ----------------------------------------------------------------- Looks good
Attachment #8840999 -
Flags: review?(ydelendik) → review+
Pushed by lwagner@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4c67f9e2c412 Baldr: store current frame, not previous frame, in wasm::FrameIterator (r=yury)
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4c67f9e2c412
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•