Closed Bug 1342551 Opened 4 years ago Closed 4 years ago

Fix unit test for storing prefill sites in a file

Categories

(Firefox :: Address Bar, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- fixed

People

(Reporter: sveta.orlik.code, Assigned: sveta.orlik.code, Mentored)

References

Details

Attachments

(1 file)

Current test takes last site from the list to test the list is fully loaded. But it omits first letter to avoid testing the match as autofill.

This will fail if there is a site in the list that has only first letter different from tested last site. For example, yahoo.com and wahoo.com.
Comment on attachment 8841103 [details]
Bug 1342551 - Fix the test loading top URLs file: last site, first letter;

https://reviewboard.mozilla.org/r/115440/#review117008

Nice catch. Sorry for the delay, I was away on Friday.
Attachment #8841103 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c7374c1837bc
Fix the test loading top URLs file: last site, first letter; r=Gijs
Assignee: nobody → sveta.orlik.code
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
https://hg.mozilla.org/mozilla-central/rev/c7374c1837bc
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Blocks: 1336946
You need to log in before you can comment on or make changes to this bug.