Fix unit test for storing prefill sites in a file

RESOLVED FIXED in Firefox 54

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sveta.orlik.code, Assigned: sveta.orlik.code, Mentored)

Tracking

Trunk
Firefox 54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
Current test takes last site from the list to test the list is fully loaded. But it omits first letter to avoid testing the match as autofill.

This will fail if there is a site in the list that has only first letter different from tested last site. For example, yahoo.com and wahoo.com.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8841103 [details]
Bug 1342551 - Fix the test loading top URLs file: last site, first letter;

https://reviewboard.mozilla.org/r/115440/#review117008

Nice catch. Sorry for the delay, I was away on Friday.
Attachment #8841103 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 3

2 years ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c7374c1837bc
Fix the test loading top URLs file: last site, first letter; r=Gijs

Updated

2 years ago
Assignee: nobody → sveta.orlik.code
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c7374c1837bc
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54

Updated

2 years ago
Blocks: 1336946
You need to log in before you can comment on or make changes to this bug.