Closed
Bug 1342721
Opened 8 years ago
Closed 8 years ago
Ensure that SpiderMonkey recursion checks are all inlines
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 1342439
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
16.09 KB,
patch
|
Details | Diff | Splinter Review |
The recursion check macros are commonly used inside SpiderMonkey but
only in a few places in Gecko. There’s currently an out-of-line call to
js::RunningWithTrustedPrincipals (a friend API unused in Gecko) which we
can eliminate by moving the macros inline inside SpiderMonkey and expose
APIs for the few Gecko consumers mentioned above.
| Assignee | ||
Comment 1•8 years ago
|
||
The recursion check macros are commonly used inside SpiderMonkey but
only in a few places in Gecko. There's currently an out-of-line call to
js::RunningWithTrustedPrincipals (a friend API unused in Gecko) which we
can eliminate by moving the macros inline inside SpiderMonkey and expose
APIs for the few Gecko consumers mentioned above.
Attachment #8841287 -
Flags: review?(sphink)
Comment 2•8 years ago
|
||
Does bug 1342439 conflict with this?
| Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Emanuel Hoogeveen [:ehoogeveen] from comment #2)
> Does bug 1342439 conflict with this?
Sigh, almost certainly. :(
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Updated•8 years ago
|
Attachment #8841287 -
Flags: review?(sphink)
You need to log in
before you can comment on or make changes to this bug.
Description
•