Closed
Bug 1342754
Opened 7 years ago
Closed 7 years ago
ImageKey id allocation conflict by Bug 1342246
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file, 2 obsolete files)
9.21 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
Since Bug 1342246 fix, ImageKey allocation causes conflicts. WebRenderBridgeChild::mIdNamespace is not unique, since root WebRenderBridgeParent and another WebRenderBridgeParents share same wr::WebRenderAPI. And get IdNamespace by WebRenderAPI::GetNamespace().
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 1•7 years ago
|
||
The following constructor also has a problem, since, sync ipc happens after the constructor. > WebRenderBridgeChild::WebRenderBridgeChild(const wr::PipelineId& aPipelineId, uint32_t aIdNamespace)
Assignee | ||
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8841323 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Summary: ImageKey allocation conflict by Bug 1342246 → ImageKey id allocation conflict by Bug 1342246
Assignee | ||
Updated•7 years ago
|
Attachment #8841324 -
Flags: review?(jmuizelaar)
Attachment #8841324 -
Flags: review?(bugmail)
Comment 4•7 years ago
|
||
Can't we just use the process id of the child for this?
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Lee Salzman [:lsalzman] from comment #4) > Can't we just use the process id of the child for this? Is there a possibility of id conflict when child processs are created/deleted repeatedly?
Comment 6•7 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #5) > (In reply to Lee Salzman [:lsalzman] from comment #4) > > Can't we just use the process id of the child for this? > > Is there a possibility of id conflict when child processs are > created/deleted repeatedly? Linux, at least, works through the entire process id space before reusing them. And also, aren't the resources created by the children here essentially only going to live as long as the children anyway, so that this becomes moot?
Updated•7 years ago
|
Attachment #8841324 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Updated•7 years ago
|
Attachment #8841324 -
Flags: review?(bugmail)
Assignee | ||
Comment 7•7 years ago
|
||
(In reply to Lee Salzman [:lsalzman] from comment #6) > > > > Is there a possibility of id conflict when child processs are > > created/deleted repeatedly? > > Linux, at least, works through the entire process id space before reusing > them. And also, aren't the resources created by the children here > essentially only going to live as long as the children anyway, so that this > becomes moot? how to allocate process is platform dependent thing and cleaning children on parent side could happen asynchronously. The order of the tasks could be inverted. Then current approach seems safer than using process id.
Assignee | ||
Comment 8•7 years ago
|
||
Rebased.
Attachment #8841324 -
Attachment is obsolete: true
Attachment #8841410 -
Flags: review+
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/709f9115cd70 Make WebRenderBridgeChild::mIdNamespace unique r=jrmuizel
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 10•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/709f9115cd70
status-firefox54:
--- → fixed
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•