134280 - opening compose window from navigator window crashes

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I crash when I open a compose window from within navigator window, either with
Ctrl-M or File -> New -> Message.  Opening it after starting with "./mozilla
-mail" or just using "./mozilla -compose" works fine.

Steps to reproduce:
 1. Start ./mozilla (without -mail)
 2. Press Ctrl-M

On IRC a bunch of people have been able to reproduce this on Windows and Linux,
but darin could not reproduce on MacOSX.  I see it in both the 2002-03-29-11
Linux tarball and in my own opt build.  smontagu has a stack from a Windows build.

Comment 1

[Simon Montagu :smontagu]

Stack trace (from a Win32 build pulled about 09:30 on 2002-3-29 and built with
clobber):

nsMsgComposeService::OpenComposeWindow(nsMsgComposeService * const 0x055716f0,
const char * 0x00000000, const char * 0x00000000, int 0x00000000, int
0x00000000, nsIMsgIdentity * 0x00000000, nsIMsgWindow * 0x00000000) line 445 +
12 bytes
XPTC_InvokeByIndex(nsISupports * 0x055716f0, unsigned int 0x00000003, unsigned
int 0x00000006, nsXPTCVariant * 0x0012b0b8) line 106
XPCWrappedNative::CallMethod(XPCCallContext & {...}, XPCWrappedNative::CallMode
CALL_METHOD) line 2025 + 42 bytes
XPC_WN_CallMethod(JSContext * 0x01513a18, JSObject * 0x0551e590, unsigned int
0x00000006, long * 0x05587050, long * 0x0012b394) line 1266 + 14 bytes
js_Invoke(JSContext * 0x01513a18, unsigned int 0x00000006, unsigned int
0x00000000) line 788 + 23 bytes
js_Interpret(JSContext * 0x01513a18, long * 0x0012c1d4) line 2745 + 15 bytes
js_Invoke(JSContext * 0x01513a18, unsigned int 0x00000001, unsigned int
0x00000002) line 805 + 13 bytes
js_InternalInvoke(JSContext * 0x01513a18, JSObject * 0x0551e4d0, long
0x0551e4e0, unsigned int 0x00000000, unsigned int 0x00000001, long * 0x0012c42c,
long * 0x0012c2fc) line 880 + 20 bytes
JS_CallFunctionValue(JSContext * 0x01513a18, JSObject * 0x0551e4d0, long
0x0551e4e0, unsigned int 0x00000001, long * 0x0012c42c, long * 0x0012c2fc) line
3412 + 31 bytes
nsJSContext::CallEventHandler(nsJSContext * const 0x04018530, void * 0x0551e4d0,
void * 0x0551e4e0, unsigned int 0x00000001, void * 0x0012c42c, int * 0x0012c430,
int 0x00000000) line 1016 + 33 bytes
nsJSEventListener::HandleEvent(nsJSEventListener * const 0x05473668, nsIDOMEvent
* 0x0518af78) line 180 + 77 bytes
nsXBLPrototypeHandler::ExecuteHandler(nsXBLPrototypeHandler * const 0x0518a998,
nsIDOMEventReceiver * 0x03fb2840, nsIDOMEvent * 0x0518af78) line 447
nsXBLWindowHandler::WalkHandlersInternal(nsIDOMEvent * 0x0518af78, nsIAtom *
0x03f1d4b0, nsIXBLPrototypeHandler * 0x0518a998) line 311 + 48 bytes
nsXBLWindowKeyHandler::WalkHandlers(nsXBLWindowKeyHandler * const 0x041b96f8,
nsIDOMEvent * 0x0518af78, nsIAtom * 0x03f1d4b0) line 183
nsXBLWindowKeyHandler::KeyPress(nsXBLWindowKeyHandler * const 0x041b96f8,
nsIDOMEvent * 0x0518af78) line 199
nsEventListenerManager::HandleEvent(nsEventListenerManager * const 0x03e3d600,
nsIPresContext * 0x0406c600, nsEvent * 0x0012f900, nsIDOMEvent * * 0x0012f2c8,
nsIDOMEventTarget * 0x03f3ccdc, unsigned int 0x00000002, nsEventStatus *
0x0012f74c) line 1648 + 41 bytes
nsXULDocument::HandleDOMEvent(nsXULDocument * const 0x03f3ccb0, nsIPresContext *
0x0406c600, nsEvent * 0x0012f900, nsIDOMEvent * * 0x0012f2c8, unsigned int
0x00000002, nsEventStatus * 0x0012f74c) line 2452
nsXULElement::HandleDOMEvent(nsXULElement * const 0x04102708, nsIPresContext *
0x0406c600, nsEvent * 0x0012f900, nsIDOMEvent * * 0x0012f2c8, unsigned int
0x00000002, nsEventStatus * 0x0012f74c) line 3479 + 39 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x03fd3860, nsIPresContext *
0x0406c600, nsEvent * 0x0012f900, nsIDOMEvent * * 0x0012f2c8, unsigned int
0x00000002, nsEventStatus * 0x0012f74c) line 3473 + 50 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x0504a0d0, nsIPresContext *
0x0406c600, nsEvent * 0x0012f900, nsIDOMEvent * * 0x0012f2c8, unsigned int
0x00000002, nsEventStatus * 0x0012f74c) line 3473 + 50 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x03fd3978, nsIPresContext *
0x0406c600, nsEvent * 0x0012f900, nsIDOMEvent * * 0x0012f2c8, unsigned int
0x00000002, nsEventStatus * 0x0012f74c) line 3473 + 50 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x050a8ac0, nsIPresContext *
0x0406c600, nsEvent * 0x0012f900, nsIDOMEvent * * 0x0012f2c8, unsigned int
0x00000002, nsEventStatus * 0x0012f74c) line 3473 + 50 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x040b5598, nsIPresContext *
0x0406c600, nsEvent * 0x0012f900, nsIDOMEvent * * 0x0012f2c8, unsigned int
0x00000002, nsEventStatus * 0x0012f74c) line 3473 + 50 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x040b56b0, nsIPresContext *
0x0406c600, nsEvent * 0x0012f900, nsIDOMEvent * * 0x0012f2c8, unsigned int
0x00000002, nsEventStatus * 0x0012f74c) line 3473 + 50 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x05230ed0, nsIPresContext *
0x0406c600, nsEvent * 0x0012f900, nsIDOMEvent * * 0x0012f2c8, unsigned int
0x00000002, nsEventStatus * 0x0012f74c) line 3473 + 50 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x05223180, nsIPresContext *
0x0406c600, nsEvent * 0x0012f900, nsIDOMEvent * * 0x0012f2c8, unsigned int
0x00000002, nsEventStatus * 0x0012f74c) line 3473 + 50 bytes
nsGenericElement::HandleDOMEvent(nsGenericElement * const 0x05223430,
nsIPresContext * 0x0406c600, nsEvent * 0x0012f900, nsIDOMEvent * * 0x0012f2c8,
unsigned int 0x00000001, nsEventStatus * 0x0012f74c) line 1672 + 50 bytes
nsHTMLInputElement::HandleDOMEvent(nsHTMLInputElement * const 0x05223430,
nsIPresContext * 0x0406c600, nsEvent * 0x0012f900, nsIDOMEvent * * 0x00000000,
unsigned int 0x00000001, nsEventStatus * 0x0012f74c) line 1380 + 29 bytes
PresShell::HandleEventInternal(nsEvent * 0x0012f900, nsIView * 0x03e4b8f8,
unsigned int 0x00000001, nsEventStatus * 0x0012f74c) line 6078 + 44 bytes
PresShell::HandleEvent(PresShell * const 0x03e3f704, nsIView * 0x03e4b8f8,
nsGUIEvent * 0x0012f900, nsEventStatus * 0x0012f74c, int 0x00000001, int &
0x00000001) line 6001 + 25 bytes
nsViewManager::HandleEvent(nsView * 0x03e4b8f8, nsGUIEvent * 0x0012f900, int
0x00000000) line 2018
nsView::HandleEvent(nsViewManager * 0x03e4b700, nsGUIEvent * 0x0012f900, int
0x00000000) line 306
nsViewManager::DispatchEvent(nsViewManager * const 0x03e4b700, nsGUIEvent *
0x0012f900, nsEventStatus * 0x0012f870) line 1869 + 23 bytes
HandleEvent(nsGUIEvent * 0x0012f900) line 83
nsWindow::DispatchEvent(nsWindow * const 0x03e4b994, nsGUIEvent * 0x0012f900,
nsEventStatus & nsEventStatus_eIgnore) line 865 + 10 bytes
nsWindow::DispatchWindowEvent(nsGUIEvent * 0x0012f900) line 886
nsWindow::DispatchKeyEvent(unsigned int 0x00000083, unsigned short 0x006d,
unsigned int 0x00000000, long 0x00000000) line 2658 + 15 bytes
nsWindow::OnChar(unsigned int 0x0000000d, unsigned int 0x00000000, unsigned char
0x01) line 2809
nsWindow::ProcessMessage(unsigned int 0x00000102, unsigned int 0x0000000d, long
0x00320001, long * 0x0012fd20) line 3441 + 52 bytes
nsWindow::WindowProc(HWND__ * 0x000e0436, unsigned int 0x00000102, unsigned int
0x0000000d, long 0x00320001) line 1130 + 27 bytes
USER32! 77e12e98()
USER32! 77e130e0()
USER32! 77e15824()
nsAppShellService::Run(nsAppShellService * const 0x03f01bb8) line 309
main1(int 0x00000001, char * * 0x00306c58, nsISupports * 0x00000000) line 1350 +
32 bytes
main(int 0x00000001, char * * 0x00306c58) line 1698 + 37 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Is this a duplicate of bug 134119?

Comment 3

[Jean-Francois Ducarroz]

looks like we access the identity parameters even when it's null! This is caused
by the recent change for supporting MDN. Let me fix it...

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The answer to my question in comment 2 is no (based on pulling and building the
changes for that bug).

Comment 5

[Joe Hewitt (gone)]

*** Bug 134281 has been marked as a duplicate of this bug. ***

Comment 6

[(not reading, please use [e-mail] instead)]

fix in hand, hewitt says he'll test.

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 8

[Jean-Francois Ducarroz]

I have a fix too which I think is better, patch coming...

Comment 9

[Jean-Francois Ducarroz]

Attachment: Proposed fix, v2

same idea than previous patch but this one will set the identity to the default
right at the beginning of the function instead of doing it especially for mdn.

null identity means default identity in message compose.

Comment 10

[(not reading, please use [e-mail] instead)]

back to ducarroz.

r/sr=sspitzer

please check in, for the upcoming respin.

Comment 11

[Jean-Francois Ducarroz]

Fix checked in

Comment 12

[esther]

Using build 20020402 on winxp, 20020401 on linux and 20020402 on Mac 9.1  this
is fixed. verified