1342831 - Devirtualize MozPromise::Request::AssertIsDead()

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1342831 - devirtualize AssertIsDead().

Review commit: https://reviewboard.mozilla.org/r/115628/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115628/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8841408 [details]
Bug 1342831 - devirtualize AssertIsDead().

https://reviewboard.mozilla.org/r/115628/#review117040

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3df33f21fab
devirtualize AssertIsDead(). r=gerald

Comment 5

[Iris Hsiao [:ihsiao]]

sorry had to back this out for test leak, like https://treeherder.mozilla.org/logviewer.html#?job_id=80309680&repo=autoland&lineNumber=4001

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e3df33f21fab407a457876519d4a6e06d51346a5&filter-searchStr=linux%20x64%20asan%20mochitests%20executed%20by%20taskcluster%20with%20e10s%20test-linux64-asan%20(bc

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43f52c13c08d
Backed out changeset e3df33f21fab for test leak

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

I can't see how changing a function to be non-virtual causes leaks...

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5ca11dea98f5c2f875f7516b6fc9348af3e7684
No leaks. I will try to land the patch again.

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8841408 [details]
Bug 1342831 - devirtualize AssertIsDead().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115628/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb4e310f3040
devirtualize AssertIsDead(). r=gerald

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb4e310f3040