Closed Bug 1342831 Opened 3 years ago Closed 3 years ago

Devirtualize MozPromise::Request::AssertIsDead()

Categories

(Core :: XPCOM, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → jwwang
Priority: -- → P3
Attachment #8841408 - Flags: review?(gsquelart)
Comment on attachment 8841408 [details]
Bug 1342831 - devirtualize AssertIsDead().

https://reviewboard.mozilla.org/r/115628/#review117040
Attachment #8841408 - Flags: review?(gsquelart) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e3df33f21fab
devirtualize AssertIsDead(). r=gerald
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43f52c13c08d
Backed out changeset e3df33f21fab for test leak
I can't see how changing a function to be non-virtual causes leaks...
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5ca11dea98f5c2f875f7516b6fc9348af3e7684
No leaks. I will try to land the patch again.
Flags: needinfo?(jwwang)
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb4e310f3040
devirtualize AssertIsDead(). r=gerald
https://hg.mozilla.org/mozilla-central/rev/eb4e310f3040
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.