Closed
Bug 1342831
Opened 7 years ago
Closed 7 years ago
Devirtualize MozPromise::Request::AssertIsDead()
Categories
(Core :: XPCOM, defect, P3)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jwwang
Priority: -- → P3
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8841408 -
Flags: review?(gsquelart)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8841408 [details] Bug 1342831 - devirtualize AssertIsDead(). https://reviewboard.mozilla.org/r/115628/#review117040
Attachment #8841408 -
Flags: review?(gsquelart) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Thanks!
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e3df33f21fab devirtualize AssertIsDead(). r=gerald
Comment 5•7 years ago
|
||
sorry had to back this out for test leak, like https://treeherder.mozilla.org/logviewer.html#?job_id=80309680&repo=autoland&lineNumber=4001 https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e3df33f21fab407a457876519d4a6e06d51346a5&filter-searchStr=linux%20x64%20asan%20mochitests%20executed%20by%20taskcluster%20with%20e10s%20test-linux64-asan%20(bc
Flags: needinfo?(jwwang)
Backout by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/43f52c13c08d Backed out changeset e3df33f21fab for test leak
Assignee | ||
Comment 7•7 years ago
|
||
I can't see how changing a function to be non-virtual causes leaks...
Assignee | ||
Comment 8•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5ca11dea98f5c2f875f7516b6fc9348af3e7684 No leaks. I will try to land the patch again.
Flags: needinfo?(jwwang)
Comment hidden (mozreview-request) |
Comment 10•7 years ago
|
||
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb4e310f3040 devirtualize AssertIsDead(). r=gerald
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/eb4e310f3040
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•