Open Bug 1342832 Opened 7 years ago Updated 7 years ago

Remove .checksetup_lib, move CPAN Meta code to Bugzilla::CPAN, and use JSON::XS for loading MYMETA.json

Categories

(Bugzilla :: Bugzilla-General, defect)

defect
Not set
normal

Tracking

()

Bugzilla 6.0

People

(Reporter: dylan, Assigned: dylanAtHome)

Details

Attachments

(1 file)

I added a bunch of weird corner-case-evading things to Makefile.PL that are unconventional for perl. At the time it seemed useful as we'd want to get Bugzilla 6 out Real Soon Now.

Meanwhile, we're not much closer to releasing, and these things occasionally crop up when debugging real problems: Specifically having META.json disagree with MYMETA.json.

This bug/patch is an attempt to remove a lot of those hacks -- which means that installing bugzilla might be more difficult in some environments -- but easier in future ones.
Assignee: nobody → dylan
Component: General → Bugzilla-General
Product: bugzilla.mozilla.org → Bugzilla
QA Contact: default-qa
Summary: Remove some of the crazy things from checksetup.pl and Makefile.PL → Remove some of the broken things from checksetup.pl and Makefile.PL
Target Milestone: --- → Bugzilla 6.0
Version: Production → unspecified
Comment on attachment 8841407 [details] [review]
[bugzilla] dylanwh:bug-1342832 > bugzilla:master

To review this, we need to test checksetup.pl the platforms we're going to support, probably:

ubuntu 14.04
centos 7
debian stable

Anything older is not worth our limited resources.
Attachment #8841407 - Flags: review?(theycallmefish)
Summary: Remove some of the broken things from checksetup.pl and Makefile.PL → Remove .checksetup_lib, move CPAN Meta code to Bugzilla::CPAN, and use JSON::XS for loading MYMETA.json
I can confirm that this code runs on debian stable, ubuntu 14.04, and centos 7. We also have it working on centos 6 and an unsupported version of perl (5.10) although checksetup.pl just fails to run unless Module::Metadata is installed -- but that situation cannot arise on a supported version of perl.
Comment on attachment 8841407 [details] [review]
[bugzilla] dylanwh:bug-1342832 > bugzilla:master

Removing the review, as dylan has completed it.
Attachment #8841407 - Flags: review?(theycallmefish)
(In reply to Dylan Hardison [:dylan] (he/him) from comment #3)
> I can confirm that this code runs on debian stable, ubuntu 14.04, and centos
> 7. We also have it working on centos 6 and an unsupported version of perl
> (5.10) although checksetup.pl just fails to run unless Module::Metadata is
> installed -- but that situation cannot arise on a supported version of perl.

Given these statements, I believe these changes to be safe to merge.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: