Closed Bug 1342838 Opened 7 years ago Closed 7 years ago

MIME emitter needs to use asciispec for external link urls for IDN domains

Categories

(MailNews Core :: MIME, defect)

Product:
MailNews Core
Component:
MIME
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird52 fixed, thunderbird53 fixed, thunderbird54 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 54.0
Tracking Flags:
Tracking Status
thunderbird52 --- fixed
thunderbird53 --- fixed
thunderbird54 --- fixed

People

(Reporter: alta88, Assigned: alta88)

Details

Attachments

(2 files, 1 obsolete file)

Sample eml with 3 external http attachments
2.43 KB, text/plain
Details
attachmentUrl.patch (whithout debug ready to check in)
2.04 KB, patch
jorgk-bmo
: review+
jorgk-bmo
: approval-comm-aurora+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review 
The nsIURI.spec value would be the utf8 string, which is received from xpcom as ISO-8859-1, and would have to be ConvertToUnicode'd and idnService.convertUTF8toACE'd for idn punycode. While asciispec already has it as ACE punycode.
Attached patch attachmentUrl.patch (obsolete) — — Splinter Review 
simple fix; debug left in to be removed on checkin.

the first 2 attachments have the idn punycode url and the utf8 url versions, respectively. they should both display inline.  upon right click Open, they should open the defined handler app for .jpg files.

the 3rd is for utf8 url paths, which works with/without the patch.
Assignee: nobody → alta88
Attachment #8841430 - Flags: review?(jorgk)
Attachment #8841429 - Attachment mime type: application/mbox → text/html
Attachment #8841429 - Attachment mime type: text/html → application/text
Attachment #8841429 - Attachment mime type: application/text → application/eml
Attachment #8841429 - Attachment mime type: application/eml → text/plain
Excellent. Thanks for the patch and the service with debug included. Nice to see you more active lately :-)

I took the liberty to remove a comment which no longer applies.
Attachment #8841430 - Attachment is obsolete: true
Attachment #8841430 - Flags: review?(jorgk)
Attachment #8841475 - Flags: review+
Status: NEW → ASSIGNED
https://hg.mozilla.org/comm-central/rev/62593187578ad6392b027b3b521b2225fdd30ba8
Uplift? This looks useful.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 54.0
Comment on attachment 8841475 [details] [diff] [review]
attachmentUrl.patch (whithout debug ready to check in)

I think this is useful to have in earlier versions since it fixes a long-standing problem. Small low-risk and well-understood patch with very limited scope (meaning: not on the main code path).
Attachment #8841475 - Flags: approval-comm-beta+
Attachment #8841475 - Flags: approval-comm-aurora+
Attachment #8841475 - Flags: approval-comm-esr52?
Comment on attachment 8841475 [details] [diff] [review]
attachmentUrl.patch (whithout debug ready to check in)

Uplift to TB 52 beta, will automatically go into TB 52 ESR.
Attachment #8841475 - Flags: approval-comm-esr52?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: