1342845 - Remove the synchronousness from nsIURIClassifier.Classify's IPC port

Status: NEW

(Toolkit :: Safe Browsing, task, P3)

Description

[Henry Chang [:hchang]]

Either in [1] or the patch part 2 in Bug 1341506, the IPC port of [2] is sync (although the result is delivered by callback.) We should fix this

[1] http://searchfox.org/mozilla-central/rev/90d1cbb4fd3dc249cdc11fe5c3e0394d22d9c680/dom/ipc/PContent.ipdl#833
[2] http://searchfox.org/mozilla-central/rev/90d1cbb4fd3dc249cdc11fe5c3e0394d22d9c680/netwerk/base/nsIURIClassifier.idl#70

Comment 1

[TomS [:toms]]

Hello. Can I work on this bug?

Comment 2

[Manish [:manishkk]]

How can I fix this?

Comment 3

[Dimi Lee [:dimi]]

(In reply to Manish [:manishkk] from comment #2)

How can I fix this?

Hi,
Thanks for helping.
First, if you haven't read about IPDL before, you could probably check here[1] to get a quick overview.

So the basic idea is to change the "sync"[2] to "async". You will have to remove the |returns (bool success);|.
We have a similar example |async PURLClassifierLocal| that you can see how it differs from the sync one.

If you have any other question, feel free to let me know :)

[1] https://developer.mozilla.org/en-US/docs/Mozilla/IPDL/Tutorial
[2] https://searchfox.org/mozilla-central/rev/90d1cbb4fd3dc249cdc11fe5c3e0394d22d9c680/dom/ipc/PContent.ipdl#833

Comment 4

[Manish [:manishkk]]

I got |async PURLClassifierLocal| : https://searchfox.org/mozilla-central/source/dom/ipc/PContent.ipdl#840
but couldn't find 'sync PURLClassifierLocal'

We have a similar example |async PURLClassifierLocal| that you can see how it differs from the sync one.

Comment 5

[Dimi Lee [:dimi]]

(In reply to Manish [:manishkk] from comment #4)

I got |async PURLClassifierLocal| : https://searchfox.org/mozilla-central/source/dom/ipc/PContent.ipdl#840
but couldn't find 'sync PURLClassifierLocal'

We have a similar example |async PURLClassifierLocal| that you can see how it differs from the sync one.

Yes, I mean you can reference the async version of PURLClassifierLocal.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Resetting the owner as no activity for 2 months

Comment 7

[TomS [:toms]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #6)

Resetting the owner as no activity for 2 months

Can I be assigned to this bug?

Comment 8

[Dimi Lee [:dimi]]

(In reply to TomS [:toms] from comment #7)

(In reply to Sylvestre Ledru [:sylvestre] from comment #6)

Resetting the owner as no activity for 2 months

Can I be assigned to this bug?

Sure!

Comment 9

[TomS [:toms]]

Thanks Dimi

Comment 10

[TomS [:toms]]

Can I do this using artifact builds? This looks like a c++ file

Comment 11

[Dimi Lee [:dimi]]

(In reply to TomS [:toms] from comment #10)

Can I do this using artifact builds? This looks like a c++ file

No, you will have to be able to build the source code.
BTW, I think this is not relative easy good-first-bug because you will have to know a little bit about ipdl.
It is still doable so please feel free to let me know if you have any question, also feel free to unassign if you want to work
on something easier first :)

Comment 12

[TomS [:toms]]

Ok. You can unassign me, there's another bug that I'm poking so I'll get started on that one for the time being. Cheers

Comment 13

[Jayati Shrivastava]

hello, May I work on this?

Comment 14

[Dimi Lee [:dimi]]

(In reply to Jayati Shrivastava from comment #13)

hello, May I work on this?

sure!

Comment 15

[Jayati Shrivastava]

Attachment: Bug 1342845 - Remove the synchronousness from nsIURIClassifier.Classify's IPC port. r=dimi