1342869 - stylo Assertion failure: child->mParent == this (We have a unique inner!), at StyleSheet.cpp:86

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Carsten Book [:Tomcat]]

found via topsite stests with bughunter and reproduced on latest stylo debug build from tinderbox

Assertion failure: child->mParent == this (We have a unique inner!), at /home/worker/workspace/build/src/layout/style/StyleSheet.cpp:86


Steps to reproduce:
-> Load http://www.coupons.com (and seems to happen on a lot of other urls)
---> Assertion failure

Comment 1

[Bobby Holley (:bholley)]

This looks related to the work that Brad's been doing.

Comment 2

[Brad Werth [:bradwerth]]

Agreed. I'll figure it out.

Comment 3

[Brad Werth [:bradwerth]]

Attachment: Bug 1342869 Part 1: Uplift ChildSheetListBuilder into StyleSheet so that all StyleSheet subclasses can fixup parent chains when children are removed.

Review commit: https://reviewboard.mozilla.org/r/115900/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115900/

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8841797 [details]
Bug 1342869 Part 1: Uplift ChildSheetListBuilder into StyleSheet so that all StyleSheet subclasses can fixup parent chains when children are removed.

https://reviewboard.mozilla.org/r/115900/#review119126

::: layout/style/StyleSheet.cpp:260
(Diff revision 1)
>  
>    mSheets.RemoveElement(aSheet);
>  }
>  
> +void
> +StyleSheet::ChildSheetListBuilder::SetParentLinks(StyleSheet* aSheet) {

Nit: may as well move the brace to a new line while this code is moving.

::: layout/style/StyleSheet.cpp:268
(Diff revision 1)
> +                                parent->mDocumentAssociationMode);
> +}
> +
> +void
> +StyleSheet::ChildSheetListBuilder::ReparentChildList(StyleSheet* aPrimarySheet,
> +                                                         StyleSheet* aFirstChild)

Nit: fix this indentation while the code is moving.

Comment 5

[Brad Werth [:bradwerth]]

Comment on attachment 8841797 [details]
Bug 1342869 Part 1: Uplift ChildSheetListBuilder into StyleSheet so that all StyleSheet subclasses can fixup parent chains when children are removed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/115900/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c679739e5df2
Part 1: Uplift ChildSheetListBuilder into StyleSheet so that all StyleSheet subclasses can fixup parent chains when children are removed. r=heycam

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c679739e5df2