Closed
Bug 1342880
Opened 7 years ago
Closed 7 years ago
Label runnables in layout/inspector/
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: TYLin, Assigned: bmo)
References
Details
(Whiteboard: [QDL][TDC-MVP][LAYOUT])
User Story
See https://wiki.mozilla.org/Quantum/DOM#Labeling for the story.
Attachments
(1 file)
No calls to NS_DispatchTo(Main|Current)Thread under layout/inspector/. Calls related to TimerCallback. http://searchfox.org/mozilla-central/search?q=TimerCallback&case=false®exp=false&path=layout%2Finspector
Assignee | ||
Comment 1•7 years ago
|
||
Yes, true. No runnables used under this code folder but only exist
Assignee: nobody → aschen
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•7 years ago
|
||
inSearchLoop.cpp is included in moz.build[1] but class inSearchLoop defined in inSearchLoop.h seems used in nowhere[2]. [1] http://searchfox.org/mozilla-central/source/layout/inspector/moz.build#34 [2] http://searchfox.org/mozilla-central/search?q=inSearchLoop&path=layout/inspector
Assignee | ||
Comment 3•7 years ago
|
||
TRY: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4dd0c77a07daf21d69cc1d9016acec902f37218&selectedJob=83646914
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8847408 -
Flags: review?(cam)
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8847408 [details] Bug 1342880 : Remove class inSearchLoop from the tree. https://reviewboard.mozilla.org/r/120386/#review122352 Looks like this file should have been removed in bug 210096, 10 years ago. :-)
Attachment #8847408 -
Flags: review?(cam) → review+
Assignee | ||
Comment 6•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8847408 [details] Bug 1342880 : Remove class inSearchLoop from the tree. https://reviewboard.mozilla.org/r/120386/#review122352 Exactly, sadly it's not removed meanwhile. Thanks for review.
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by tlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e511e1218d7f Remove class inSearchLoop from the tree. r=heycam
Keywords: checkin-needed
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e511e1218d7f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•7 years ago
|
Whiteboard: [QDL][TDC-MVP][LAYOUT]
You need to log in
before you can comment on or make changes to this bug.
Description
•