Closed Bug 1342880 Opened 3 years ago Closed 3 years ago

Label runnables in layout/inspector/

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: TYLin, Assigned: bmo)

References

Details

(Whiteboard: [QDL][TDC-MVP][LAYOUT])

User Story

See https://wiki.mozilla.org/Quantum/DOM#Labeling for the story.

Attachments

(1 file)

No calls to NS_DispatchTo(Main|Current)Thread under layout/inspector/.

Calls related to TimerCallback.

http://searchfox.org/mozilla-central/search?q=TimerCallback&case=false&regexp=false&path=layout%2Finspector
Yes, true. No runnables used under this code folder but only exist
Assignee: nobody → aschen
Status: NEW → ASSIGNED
inSearchLoop.cpp is included in moz.build[1] but class inSearchLoop defined in inSearchLoop.h seems used in nowhere[2].

[1] http://searchfox.org/mozilla-central/source/layout/inspector/moz.build#34
[2] http://searchfox.org/mozilla-central/search?q=inSearchLoop&path=layout/inspector
Attachment #8847408 - Flags: review?(cam)
Comment on attachment 8847408 [details]
Bug 1342880 : Remove class inSearchLoop from the tree.

https://reviewboard.mozilla.org/r/120386/#review122352

Looks like this file should have been removed in bug 210096, 10 years ago. :-)
Attachment #8847408 - Flags: review?(cam) → review+
Comment on attachment 8847408 [details]
Bug 1342880 : Remove class inSearchLoop from the tree.

https://reviewboard.mozilla.org/r/120386/#review122352

Exactly, sadly it's not removed meanwhile. Thanks for review.
Keywords: checkin-needed
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e511e1218d7f
Remove class inSearchLoop from the tree. r=heycam
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e511e1218d7f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Blocks: 1347815
No longer blocks: 1347815
Whiteboard: [QDL][TDC-MVP][LAYOUT]
You need to log in before you can comment on or make changes to this bug.