1342887 - Intermittent test_fallback_update.py TestFallbackUpdate.test_update | TimeoutException: Timed out after 300.1 seconds with message: Update has been applied.

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Treeherder Bug Filer]

Filed by: hskupin [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=80252455&repo=mozilla-central

https://firefox-ui-tests.s3.amazonaws.com/18010e0f-ab55-48ad-ac11-fadcba6b40bf/log_info.log

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is an new issue which started recently for OS X and mozilla-central only. As it looks like around February the 18th.

Matt and Rob, did we had changes to the updater lately, which could have caused a very long delay in applying the update? Here we run out of time after 300s.

Comment 2

[Molly Howell (she/her) (mostly inactive)]

The only recent Mac-specific thing I know of was bug 1335916, but that landed on the 10th. Do you know of a way that could have started causing failures to appear around the 18th instead of the 10th?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The changes as done in this patch might indicate a possible hang like noticed on this bug. I had another look at Treeherder and noticed a gap between 17th and 13th of February. So the earliest test failure we have is from February 13th:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=fxup-nightly%20os%20x&filter-tier=1&filter-tier=2&filter-tier=3&bugfiler&fromchange=4dfd0d2d5dd3b640d46ee405af7523e37545c155&selectedJob=76815040

Then no test failure until February 17th:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=fxup-nightly%20os%20x&filter-tier=1&filter-tier=2&filter-tier=3&bugfiler&fromchange=4dfd0d2d5dd3b640d46ee405af7523e37545c155&selectedJob=78565274

Then another time with no failures and perma failure for at least the machine osx-10-10-2 since Tuesday.

Btw. today David Burns also mentioned to me a hang during applying updates for Nightly on OS X, which forced him to kill Firefox. Maybe that has the same underlying issue.

Comment 4

[Molly Howell (she/her) (mostly inactive)]

Attachment: Bug 1342887 - Detect and log failures to dispatch SetupMacCommandLine to the main thread.

Review commit: https://reviewboard.mozilla.org/r/115874/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115874/

Comment 5

[Molly Howell (she/her) (mostly inactive)]

Don't close this bug immediately after landing this patch, because I'm not certain it will completely solve the problem. But at least the new logging might help.

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 8841741 [details]
Bug 1342887 - Detect and log failures to dispatch SetupMacCommandLine to the main thread.

https://reviewboard.mozilla.org/r/115874/#review117254

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3120e572493a
Detect and log failures to dispatch SetupMacCommandLine to the main thread. r=rstrong

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3120e572493a

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Matt, I haven't seen this test failure anymore for our update tests on central. So I assume that we can this marked as fixed? Would an uplift to aurora be helpful?

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Oh, checking the landed patch on hg.mo, this should actually have been fixed for 54.0.

Comment 11

[Molly Howell (she/her) (mostly inactive)]

Sure, if you're not seeing this failure anymore, then I'd say this bug is resolved. I'll mark it as such.

Comment 12

[Intermittent Failures Robot]

3 failures in 423 pushes (0.007 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-beta: 3

Platform breakdown:
* linux64: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1342887&startday=2017-12-11&endday=2017-12-17&tree=all

Comment 13

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.