1342900 - Remove usage of nsTArray<nsAutoPtr<>> in Classifier

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P2)

Description

[Gian-Carlo Pascutto [:gcp]]

https://dxr.mozilla.org/mozilla-central/rev/16effd5b21ab03629feca04b5b83911bb757394c/toolkit/components/url-classifier/Classifier.cpp#65

It's very surprising nsTArray<nsAutoPtr<>> compiles, let alone works at all (if it really does, actually). This usage is expressly forbidden by auto_ptr because it's extremely prone to errors: containers generally assume that internal values can be copied, but copying an auto_ptr transfers ownership, so it does not have real copy semantics.

UniquePtr should be used as it does not suffer from this problem.

Comment 1

[Chung-Sheng Fu [:cfu]]

Attachment: Bug 1342900 - Remove usage of nsTArray<nsAutoPtr<>> in Classifier.

Review commit: https://reviewboard.mozilla.org/r/136418/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136418/

Comment 2

[Dimi Lee [:dimi]]

Comment on attachment 8864753 [details]
Bug 1342900 - Remove usage of nsTArray<nsAutoPtr<>> in Classifier.

https://reviewboard.mozilla.org/r/136418/#review139554

Looks good to me! Thanks.

Comment 3

[Chung-Sheng Fu [:cfu]]

Comment on attachment 8864753 [details]
Bug 1342900 - Remove usage of nsTArray<nsAutoPtr<>> in Classifier.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136418/diff/1-2/

Comment 4

[Carsten Book [:Tomcat]]

needs final review/ship it so we can use autolander. thanks

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/170fee4541a3
Remove usage of nsTArray<nsAutoPtr<>> in Classifier. r=dimi

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/170fee4541a3

Comment 7

[Ethan Tseng [:ethan]]

Chung-Sheng,
Congratulations to your good first bug!!  ;)