1342914 - Add-ons Manager ”Enable” button should not be clickable as long as permissions pop-up is displayed

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: gif1.gif

[Affected versions]:
Firefox 54.0a1 (2017-02-27)
Firefox 53.0a2 (2017-02-27)

[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit


[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Create extensions.webextPermissionPrompts and set it to true.
3.Install via sideloading method a webextension with permissions. 
4.After reopening the browser, open to Panel Menu [≡] and click on sideloading notification.
5.Click on Add-ons Manager “Enable” button (not the one from permissions pop-up).  


[Expected Results]:
Add-ons Manager “Enable” button is not clickable as long as permissions pop-up is displayed.


[Actual Results]:
The webextension can be enabled from Add-ons Manager “Enable” button even if permissions doorhanger is being displayed.

[Additional Notes]:
Due to Bug 1334096, while a webextensions is enabled avoiding the classical sideloading flow, the Add-ons Manager “Enable” button is not clickable as long as permissions pop-up is displayed. See screencast: https://www.screencast.com/t/0Xpjcarv

Comment 1

[:shell escalante]

rhelmer: if we listen for the state, easily fixable

Comment 2

[:shell escalante]

believe resolved in Nightly - so this should work now... would you mind retesting

Comment 3

[Vasilica Tamas, QA [:vtamas]]

Attachment: Animation.gif

Retested and it seems that this issue still reproduces on Firefox 55.0a1 (2017-04-19) and Firefox 54.0a1 (2017-04-18) under Windows 10 64-bit and Ubuntu 16.04 32-bit. 

Please see attached screencast.

Comment 4

[Andy McKay]

Given that we are planning on replacing the add-ons manager, I'm going to won't fix this for now.