Closed Bug 1342959 Opened 3 years ago Closed 3 years ago

Update merge day scripts after esr52 meges

Categories

(Release Engineering :: Release Requests, defect, P1)

defect

Tracking

(firefox54 fixed)

RESOLVED FIXED
Tracking Status
firefox54 --- fixed

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8841605 [details]
Bug 1342959 - Update merge day scripts after esr52 meges  DONTBUILD

https://reviewboard.mozilla.org/r/115758/#review117222

::: testing/mozharness/scripts/merge_day/gecko_migration.py:407
(Diff revision 1)
>      def apply_replacements(self):
>          dirs = self.query_abs_dirs()
>          for f, from_, to in self.config["replacements"]:
>              self.replace(os.path.join(dirs['abs_to_dir'], f), from_, to)
>  
>      def transplant(self, repo, changeset, cwd):

would `graft` here and in the docstring make more sense than `transplant`?
Attachment #8841605 - Flags: review?(jlund) → review+
Attachment #8841605 - Flags: review+ → review?(jlund)
Comment on attachment 8841605 [details]
Bug 1342959 - Update merge day scripts after esr52 meges  DONTBUILD

https://reviewboard.mozilla.org/r/115758/#review117602

lgtm :)
Attachment #8841605 - Flags: review?(jlund) → review+
Pushed by raliiev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9871ce99a2a
Update merge day scripts after esr52 meges r=jlund DONTBUILD
https://hg.mozilla.org/mozilla-central/rev/a9871ce99a2a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
See Also: → 1452969
You need to log in before you can comment on or make changes to this bug.