1342964 - Update Harfbuzz to 1.4.3

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Tom Ritter [:tjr]]

This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library.

Harfbuzz is currently at version 1.4.2 in mozilla-central, and the latest version of the library released is 1.4.3. 

I fetched the latest version of the library from https://github.com/behdad/harfbuzz/.

You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

First attempt at a Try push isn't going well:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4726ed40db1fbcec2938a25ebcea09b012c6d40a

https://treeherder.mozilla.org/logviewer.html#?job_id=80490034&repo=try

gfx/harfbuzz/src/hb-fallback-shape.cc:31:237: error: 'struct hb_shaper_data_t' has no member named 'fallback'
gfx/harfbuzz/src/hb-fallback-shape.cc:31:348: error: '_hb_fallback_shaper_face_data_create' was not declared in this scope
gfx/harfbuzz/src/hb-fallback-shape.cc:31:550: error: 'struct hb_shaper_data_t' has no member named 'fallback'
gfx/harfbuzz/src/hb-fallback-shape.cc:31:670: error: 'struct hb_shaper_data_t' has no member named 'fallback'
gfx/harfbuzz/src/hb-fallback-shape.cc:31:824: error: '_hb_fallback_shaper_face_data_destroy' was not declared in this scope
gfx/harfbuzz/src/hb-fallback-shape.cc:32:237: error: 'struct hb_shaper_data_t' has no member named 'fallback'
gfx/harfbuzz/src/hb-fallback-shape.cc:32:348: error: '_hb_fallback_shaper_font_data_create' was not declared in this scope
gfx/harfbuzz/src/hb-fallback-shape.cc:32:550: error: 'struct hb_shaper_data_t' has no member named 'fallback'
gfx/harfbuzz/src/hb-fallback-shape.cc:32:670: error: 'struct hb_shaper_data_t' has no member named 'fallback'
gfx/harfbuzz/src/hb-fallback-shape.cc:32:824: error: '_hb_fallback_shaper_font_data_destroy' was not declared in this scope

Comment 2

[Behdad Esfahbod]

That's because you have not defined HAVE_FALLBACK but are compiling hb-fallback-shape.cc.  Remove that file from compile list; it's unused by Firefox.  Or define HAVE_FALLBACK instead. I marginally prefer the latter.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: update harfbuzz to version 1.4.3

Indeed, that went a bit better :)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b717d73379e3ec665e200592f487b0a5c08b325

Comment 4

[Jonathan Kew [:jfkthame]]

(In reply to Behdad Esfahbod from comment #2)
> That's because you have not defined HAVE_FALLBACK but are compiling
> hb-fallback-shape.cc.  Remove that file from compile list; it's unused by
> Firefox.  Or define HAVE_FALLBACK instead. I marginally prefer the latter.

Curious why you prefer that -- are you aware of cases where we might need it?

Comment 5

[Behdad Esfahbod]

(In reply to Jonathan Kew (:jfkthame) from comment #4)
> (In reply to Behdad Esfahbod from comment #2)
> > That's because you have not defined HAVE_FALLBACK but are compiling
> > hb-fallback-shape.cc.  Remove that file from compile list; it's unused by
> > Firefox.  Or define HAVE_FALLBACK instead. I marginally prefer the latter.
> 
> Curious why you prefer that -- are you aware of cases where we might need it?

In the past, in at least one occasion I set HB_SHAPER_LIST env var and checked Firefox behavior in a useful way. That doesn't work anymore, because HAVE_FALLBACK is undefined now.  It will be useful as baseline for performance measurements, but I don't see myself using it anytime soon. So, yeah, feel free to just not compile.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Attachment: update harfbuzz to version 1.4.3

Removes hb-fallback-shape.cc from moz.build per the earlier discussion. Looking green on Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=955145cfa9a2fa7edd548be9d45b47090df51683&group_state=expanded

Comment 7

[Jonathan Kew [:jfkthame]]

Comment on attachment 8842447 [details] [diff] [review]
update harfbuzz to version 1.4.3

Review of attachment 8842447 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/39a67f6289c4
Update harfbuzz to version 1.4.3. r=jfkthame

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/39a67f6289c4