Closed
Bug 1343108
Opened 9 years ago
Closed 9 years ago
Clean up obsolete $httpProvider defaults
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
Details
Attachments
(1 file)
These are redundant:
// avoid CORS issue when getting the logs from the ftp site
$httpProvider.defaults.useXDomain = true;
delete $httpProvider.defaults.headers.common['X-Requested-With'];
`useXDomain` never actually did anything since the PR that proposed it was never merged:
https://github.com/angular/angular.js/issues/2956#issuecomment-19493940
And deleting the 'X-Requested-With' header isn't required as of Angular >1.1.x :
https://github.com/angular/angular.js/issues/11008
https://github.com/angular/angular.js/commit/3a75b1124d062f64093a90b26630938558909e8d
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8849798 -
Flags: review?(cdawson)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8849798 [details] [review]
[treeherder] mozilla:httpprovider-defaults-cleanup > mozilla:master
Cool! :)
Attachment #8849798 -
Flags: review?(cdawson) → review+
|
||
Comment 3•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/c94586ab6d77eb24def5b4bac31746c3458b0984
Bug 1343108 - Clean up obsolete $httpProvider defaults
`useXDomain` never actually did anything since the PR that proposed it
was never merged:
https://github.com/angular/angular.js/issues/2956#issuecomment-19493940
And deleting the 'X-Requested-With' header isn't required as of
Angular >1.1.x :
https://github.com/angular/angular.js/issues/11008
https://github.com/angular/angular.js/commit/3a75b1124d062f64093a90b26630938558909e8d
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•