Closed Bug 1343155 Opened 8 years ago Closed 8 years ago

Reinstate -Fdgenerated.pdb for non-ccache builds

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: away, Assigned: ted)

References

Details

Continuing from bug 1322703 comment 12: (In reply to Ted Mielczarek [:ted.mielczarek] from comment #12) > (In reply to David Major [:dmajor] from comment #11) > > (In reply to David Major [:dmajor] from comment #10) > > > My opt xul.dll is taking nearly 4 minutes to link today, compared to about 2 > > > minutes last week, and I bet this change is the culprit. > > > > If the purpose of this change was to please ccache, does it need to happen > > in non-ccache builds? > > It doesn't, but because this code lived in the recursive make backend it > made things a lot simpler to have a single codepath there. We can change > that to make life better. (but also we should fix bug 1341504!) Ted, are you able to take this?
Flags: needinfo?(ted)
I backed out my change in bug 1322703. I'll work on a better patch.
Assignee: nobody → ted
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(ted)
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.