1343159 - stylo: Assertion failure: floatStyle == StyleFloat::Left || floatStyle == StyleFloat::Right (Unexpected float style!), at /home/worker/workspace/build/src/layout/generic/nsFloatManager.cpp:287

Status: RESOLVED WORKSFORME

(Core :: Layout, defect, P3)

Description

[Carsten Book [:Tomcat]]

Attachment: bughunter stack

Assertion failure: floatStyle == StyleFloat::Left || floatStyle == StyleFloat::Right (Unexpected float style!), at /home/worker/workspace/build/src/layout/generic/nsFloatManager.cpp:287

found via bughunter and reproduced on latest stylo debug build from tinderbox.

Steps to reproduce:
-> Load http://www.ti.com
--> Assertion failure

Comment 1

[Bobby Holley (:bholley)]

This is probably another good one for Manish's plate when he has time.

Comment 2

[Manish Goregaokar [:manishearth]]

I can't seem to repro this. Does bughunter use some special setup (or could you show me how to retrigger this with a newer build?)

Comment 3

[Carsten Book [:Tomcat]]

(In reply to Manish Goregaokar [:manishearth] from comment #2)
> I can't seem to repro this. Does bughunter use some special setup (or could
> you show me how to retrigger this with a newer build?)

seems this does not reproduce for me also so far. (for this case it just used a tinderbox debug stylo build on linux and crashed when i filed the bug) 

What i see in the terminal window is a kind of loop with 
WARN:geckoservo::glue: Calling Servo_ResolvePseudoStyle on unstyled element
and
[Child 5608] WARNING: stylo: Skipping Unsupported binding re-resolve. This needs fixing.: file /home/worker/workspace/build/src/layout/base/nsCSSFrameConstructor.cpp, line 5760

and the site has problems load in this debug build also

Comment 4

[Manish Goregaokar [:manishearth]]

Yeah, I was getting some looping too, but not deterministically -- it only happened once and I couldn't repro.

bholley, is this something you would know about? Seems to be something to do with pseudos.

Comment 5

[Bobby Holley (:bholley)]

Yeah not worth spending time on this one until bug 1331047 lands.

Comment 6

[Cameron McCormack (:heycam)]

I can't seem to reproduce this either, so optimistically resolving WORKSFORME.