Closed
Bug 1343174
Opened 8 years ago
Closed 8 years ago
selectOrAddTab/getTabWithURL doesn't correctly handle zombie tabs
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox54 wontfix, firefox55 fixed)
RESOLVED
FIXED
Firefox 55
People
(Reporter: JanH, Assigned: JanH)
References
Details
Attachments
(3 files)
We just query browser.currentURI, which unless I'm mistaken will be "about:blank" when dealing with zombie tabs.
We need to fall back to the session store data in that case to handle this correctly, although depending on how it pans out, bug 1343090 might also present an alternative approach.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8842141 [details]
Bug 1343174 - Part 1 - When looking for tabs with the same URL, fall back to the session store data for zombie tabs.
https://reviewboard.mozilla.org/r/116066/#review119336
Attachment #8842141 -
Flags: review?(ahunt) → review+
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8842142 [details]
Bug 1343174 - Part 2 - Rewrite test_selectoraddtab to track tabs instead of browsers.
https://reviewboard.mozilla.org/r/116068/#review119340
Attachment #8842142 -
Flags: review?(ahunt) → review+
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8842143 [details]
Bug 1343174 - Part 3 - Test that selectOrAddTab() finds zombified tabs as well.
https://reviewboard.mozilla.org/r/116070/#review119342
Attachment #8842143 -
Flags: review?(ahunt) → review+
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/adc6bebaff1d
Part 1 - When looking for tabs with the same URL, fall back to the session store data for zombie tabs. r=ahunt
https://hg.mozilla.org/integration/autoland/rev/8c914488df8c
Part 2 - Rewrite test_selectoraddtab to track tabs instead of browsers. r=ahunt
https://hg.mozilla.org/integration/autoland/rev/6dee9c5fcc9f
Part 3 - Test that selectOrAddTab() finds zombified tabs as well. r=ahunt
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/adc6bebaff1d
https://hg.mozilla.org/mozilla-central/rev/8c914488df8c
https://hg.mozilla.org/mozilla-central/rev/6dee9c5fcc9f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 9•8 years ago
|
||
I'm assuming this doesn't need to go in 54, feel free to reset the flag and request uplift if I'm mistaken.
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•