Closed Bug 1343174 Opened 3 years ago Closed 3 years ago

selectOrAddTab/getTabWithURL doesn't correctly handle zombie tabs

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox54 --- wontfix
firefox55 --- fixed

People

(Reporter: JanH, Assigned: JanH)

References

Details

Attachments

(3 files)

We just query browser.currentURI, which unless I'm mistaken will be "about:blank" when dealing with zombie tabs.

We need to fall back to the session store data in that case to handle this correctly, although depending on how it pans out, bug 1343090 might also present an alternative approach.
Comment on attachment 8842141 [details]
Bug 1343174 - Part 1 - When looking for tabs with the same URL, fall back to the session store data for zombie tabs.

https://reviewboard.mozilla.org/r/116066/#review119336
Attachment #8842141 - Flags: review?(ahunt) → review+
Comment on attachment 8842142 [details]
Bug 1343174 - Part 2 - Rewrite test_selectoraddtab to track tabs instead of browsers.

https://reviewboard.mozilla.org/r/116068/#review119340
Attachment #8842142 - Flags: review?(ahunt) → review+
Comment on attachment 8842143 [details]
Bug 1343174 - Part 3 - Test that selectOrAddTab() finds zombified tabs as well.

https://reviewboard.mozilla.org/r/116070/#review119342
Attachment #8842143 - Flags: review?(ahunt) → review+
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/adc6bebaff1d
Part 1 - When looking for tabs with the same URL, fall back to the session store data for zombie tabs. r=ahunt
https://hg.mozilla.org/integration/autoland/rev/8c914488df8c
Part 2 - Rewrite test_selectoraddtab to track tabs instead of browsers. r=ahunt
https://hg.mozilla.org/integration/autoland/rev/6dee9c5fcc9f
Part 3 - Test that selectOrAddTab() finds zombified tabs as well. r=ahunt
I'm assuming this doesn't need to go in 54, feel free to reset the flag and request uplift if I'm mistaken.
You need to log in before you can comment on or make changes to this bug.