Closed Bug 1343191 Opened 3 years ago Closed 3 years ago
Fix reported cache size overflow in about:cache
(In reply to Michal Novotny (:michal) from comment #6) > Yes, "Storage in use" is wrong here. The size overflows here > http://searchfox.org/mozilla-central/rev/ > 4039fb4c5833706f6880763de216974e00ba096c/netwerk/cache2/CacheStorageService. > cpp#448 Should be mSize = static_cast<uint64_t>(size) << 10;
Despite the change in about-cache is probably not needed, make sure it builds. https://treeherder.mozilla.org/#/jobs?repo=try&revision=1336dbe547b2bf7f53d0fc7a18da35b95dd33f87
Attachment #8842417 - Flags: review?(michal.novotny)
Attachment #8842417 - Flags: review?(michal.novotny) → review+
Needs care: /builds/slave/try-l64-st-an-d-00000000000000/build/src/netwerk/protocol/about/nsAboutCache.cpp:343:13: error: call to member function 'AppendInt' is ambiguous
The 1024UUL part is not necessary. The result has size of the left operand.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/81930cfe9182 Displayed HTTP cache occupation size may overflow. r=michal
You need to log in before you can comment on or make changes to this bug.