Closed Bug 1343191 Opened 3 years ago Closed 3 years ago

Fix reported cache size overflow in about:cache

Categories

(Core :: Networking: Cache, defect)

Product:
Core
Component:
Networking: Cache
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: mayhemer, Assigned: mayhemer)

Details

(Whiteboard: [necko-active])

Attachments

(1 file, 1 obsolete file)

v2
914 bytes, patch
mayhemer
: review+
Details | Diff | Splinter Review 
(In reply to Michal Novotny (:michal) from comment #6)
> Yes, "Storage in use" is wrong here. The size overflows here
> http://searchfox.org/mozilla-central/rev/
> 4039fb4c5833706f6880763de216974e00ba096c/netwerk/cache2/CacheStorageService.
> cpp#448

Should be mSize = static_cast<uint64_t>(size) << 10;
Attached patch v1 (obsolete) — — Splinter Review 
Despite the change in about-cache is probably not needed, make sure it builds.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1336dbe547b2bf7f53d0fc7a18da35b95dd33f87
Attachment #8842417 - Flags: review?(michal.novotny)
Attachment #8842417 - Flags: review?(michal.novotny) → review+
Needs care:

/builds/slave/try-l64-st-an-d-00000000000000/build/src/netwerk/protocol/about/nsAboutCache.cpp:343:13: error: call to member function 'AppendInt' is ambiguous
Whiteboard: [necko-active]
Attached patch v2 — — Splinter Review 
The 1024UUL part is not necessary.  The result has size of the left operand.
Attachment #8842417 - Attachment is obsolete: true
Attachment #8842492 - Flags: review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81930cfe9182
Displayed HTTP cache occupation size may overflow. r=michal
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/81930cfe9182
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.