1343191 - Fix reported cache size overflow in about:cache

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Honza Bambas (:mayhemer)]

(In reply to Michal Novotny (:michal) from comment #6)
> Yes, "Storage in use" is wrong here. The size overflows here
> http://searchfox.org/mozilla-central/rev/
> 4039fb4c5833706f6880763de216974e00ba096c/netwerk/cache2/CacheStorageService.
> cpp#448

Should be mSize = static_cast<uint64_t>(size) << 10;

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: v1

Despite the change in about-cache is probably not needed, make sure it builds.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1336dbe547b2bf7f53d0fc7a18da35b95dd33f87

Comment 2

[Honza Bambas (:mayhemer)]

Needs care:

/builds/slave/try-l64-st-an-d-00000000000000/build/src/netwerk/protocol/about/nsAboutCache.cpp:343:13: error: call to member function 'AppendInt' is ambiguous

Comment 3

[Honza Bambas (:mayhemer)]

Attachment: v2

The 1024UUL part is not necessary.  The result has size of the left operand.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81930cfe9182
Displayed HTTP cache occupation size may overflow. r=michal

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81930cfe9182