1343226 - Investigate Send Tab from iOS -> Desktop

Status: RESOLVED DUPLICATE of bug 1373276

(Firefox for iOS :: Firefox Accounts, defect)

Description

[James Hugman [:jhugman] [@jhugman]]

It isn't clear how this currently works. (sending sync commands)

Once Bug 1333765 is resolved, do we need to update the sending of tabs to other devices? Does Firefox for iOS need to be able to send WebPush notifications directly?

Comment 1

[:Grisha Kruglov]

After syncing clients records updated with commands, Android notifies other clients via devices/notify endpoint: https://github.com/mozilla/fxa-auth-server/blob/master/docs/api.md#post-v1accountdevicesnotify

Relevant code: https://dxr.mozilla.org/mozilla-central/source/mobile/android/services/src/main/java/org/mozilla/gecko/sync/stage/SyncClientsEngineStage.java#184

Comment 2

[Richard Newman [:rnewman]]

(In reply to James Hugman [:jhugman] [@jhugman] from comment #0)

> It isn't clear how this currently works. (sending sync commands)

The SendTo extension:

  https://github.com/mozilla-mobile/firefox-ios/tree/master/Extensions/SendTo

writes commands into storage:

  https://github.com/mozilla-mobile/firefox-ios/blob/master/Storage/SQL/SQLiteRemoteClientsAndTabs.swift#L282

which are then uploaded during a sync of the clients engine:

  https://github.com/mozilla-mobile/firefox-ios/blob/master/Sync/Synchronizers/ClientsSynchronizer.swift#L202

Other commands, like remote wipes, would also end up in that commands table, and would follow the same path out the door.

Comment 3

[Richard Newman [:rnewman]]

(In reply to James Hugman [:jhugman] [@jhugman] from comment #0)

> Once Bug 1333765 is resolved, do we need to update the sending of tabs to
> other devices? Does Firefox for iOS need to be able to send WebPush
> notifications directly?

The equivalent to Android's approach is to make ClientsSynchronizer issue a devices/notify ping after successfully uploading a client's record.

Comment 4

[James Hugman [:jhugman] [@jhugman]]

> It isn't clear how this currently works.
It wasn't clear to _me_. :)

Thanks :grisha :rnewman.

Closing this now work on Bug 1373276 has started.