Closed
Bug 1343226
Opened 7 years ago
Closed 7 years ago
Investigate Send Tab from iOS -> Desktop
Categories
(Firefox for iOS :: Firefox Accounts, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1373276
People
(Reporter: jhugman, Unassigned)
References
Details
It isn't clear how this currently works. (sending sync commands) Once Bug 1333765 is resolved, do we need to update the sending of tabs to other devices? Does Firefox for iOS need to be able to send WebPush notifications directly?
Comment 1•7 years ago
|
||
After syncing clients records updated with commands, Android notifies other clients via devices/notify endpoint: https://github.com/mozilla/fxa-auth-server/blob/master/docs/api.md#post-v1accountdevicesnotify Relevant code: https://dxr.mozilla.org/mozilla-central/source/mobile/android/services/src/main/java/org/mozilla/gecko/sync/stage/SyncClientsEngineStage.java#184
Comment 2•7 years ago
|
||
(In reply to James Hugman [:jhugman] [@jhugman] from comment #0) > It isn't clear how this currently works. (sending sync commands) The SendTo extension: https://github.com/mozilla-mobile/firefox-ios/tree/master/Extensions/SendTo writes commands into storage: https://github.com/mozilla-mobile/firefox-ios/blob/master/Storage/SQL/SQLiteRemoteClientsAndTabs.swift#L282 which are then uploaded during a sync of the clients engine: https://github.com/mozilla-mobile/firefox-ios/blob/master/Sync/Synchronizers/ClientsSynchronizer.swift#L202 Other commands, like remote wipes, would also end up in that commands table, and would follow the same path out the door.
Comment 3•7 years ago
|
||
(In reply to James Hugman [:jhugman] [@jhugman] from comment #0) > Once Bug 1333765 is resolved, do we need to update the sending of tabs to > other devices? Does Firefox for iOS need to be able to send WebPush > notifications directly? The equivalent to Android's approach is to make ClientsSynchronizer issue a devices/notify ping after successfully uploading a client's record.
Reporter | ||
Comment 4•7 years ago
|
||
> It isn't clear how this currently works. It wasn't clear to _me_. :) Thanks :grisha :rnewman. Closing this now work on Bug 1373276 has started.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•