Closed Bug 1343253 Opened 3 years ago Closed 3 years ago

Enable AA and Subpixel AA in Webrender

Categories

(Core :: Graphics: WebRender, defect)

53 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: mchang, Assigned: mchang)

References

Details

Attachments

(1 file)

We used to have AA / subpixel AA enabled by default in WR, but that was turned off for some reason. Turn it back on.
Attachment #8842022 - Flags: review?(milan)
Comment on attachment 8842022 [details] [diff] [review]
Enable AA / subpixel AA

Review of attachment 8842022 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable to me, but I don't really know what this does :)  It does not on its own fix the crashes, I think I need the other pull request as well.
Attachment #8842022 - Flags: review?(milan) → review+
(In reply to Milan Sreckovic [:milan] from comment #2)
> Comment on attachment 8842022 [details] [diff] [review]
> Enable AA / subpixel AA
> 
> Review of attachment 8842022 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Seems reasonable to me, but I don't really know what this does :)  It does
> not on its own fix the crashes, I think I need the other pull request as
> well.

I can open a few sites until we start crashing in wr_api_add_raw_font, which is a different issue. But at least this seems to fix the crash on start up I've been getting.

Try looks good - https://treeherder.mozilla.org/#/jobs?repo=try&revision=40cfca5a322feca150cb56285f6c923836ffb05b
That sounds about what I'm getting as well.
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/39628e255960
Enable AA and Subpixel AA in Webrender. r=milan
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.