1343253 - Enable AA and Subpixel AA in Webrender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Mason Chang [Inactive] [:mchang]]

We used to have AA / subpixel AA enabled by default in WR, but that was turned off for some reason. Turn it back on.

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Enable AA / subpixel AA

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8842022 [details] [diff] [review]
Enable AA / subpixel AA

Review of attachment 8842022 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable to me, but I don't really know what this does :)  It does not on its own fix the crashes, I think I need the other pull request as well.

Comment 3

[Mason Chang [Inactive] [:mchang]]

(In reply to Milan Sreckovic [:milan] from comment #2)
> Comment on attachment 8842022 [details] [diff] [review]
> Enable AA / subpixel AA
> 
> Review of attachment 8842022 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Seems reasonable to me, but I don't really know what this does :)  It does
> not on its own fix the crashes, I think I need the other pull request as
> well.

I can open a few sites until we start crashing in wr_api_add_raw_font, which is a different issue. But at least this seems to fix the crash on start up I've been getting.

Try looks good - https://treeherder.mozilla.org/#/jobs?repo=try&revision=40cfca5a322feca150cb56285f6c923836ffb05b

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

That sounds about what I'm getting as well.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/39628e255960
Enable AA and Subpixel AA in Webrender. r=milan

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/39628e255960