1343275 - Make the text control editor state's GetSelectionRange codepath a bit faster when going via the selection controller

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We can get rid of some virtual calls and refcounting and stuff.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Get selection faster in some nsTextEditorState methods

MozReview-Commit-ID: 2v0r3jtua1O

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Use slightly faster APIs for getting the information we want out of a selection when converting it to a text-control selection range

MozReview-Commit-ID: 6NRoWNqb1pC

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fc55ce02ba5
part 1.  Get selection faster in some nsTextEditorState methods.  r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/32e54e6e8c02
part 2.  Use slightly faster APIs for getting the information we want out of a selection when converting it to a text-control selection range.  r=ehsan

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=82842964&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee52a1c26048

Comment 5

[Boris Zbarsky [:bzbarsky]]

The issue is the patches for bug 1345237.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Er, bug 1343037.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5df501fbf40d
part 1.  Get selection faster in some nsTextEditorState methods.  r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b1392f47637
part 2.  Use slightly faster APIs for getting the information we want out of a selection when converting it to a text-control selection range.  r=ehsan

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5df501fbf40d
https://hg.mozilla.org/mozilla-central/rev/5b1392f47637