Closed
Bug 1343286
Opened 8 years ago
Closed 8 years ago
Delete unused calendar/lightning/build/universal.mk
Categories
(Calendar :: Build Config, defect, P5)
Calendar
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
5.7
People
(Reporter: frg, Assigned: frg)
References
Details
Attachments
(1 file)
|
2.08 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
Bug 1342629 removed calendar/lightning/build/universal.mk from the SeaMonkey OSX build mozconfigs because OSX universal builds are no longer done. It was already removed from the Thunderbird build configs and is no longer used in the comm-central and comm-aurora trees so the file can be deleted.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8842076 -
Flags: review?(philipp)
Attachment #8842076 -
Flags: approval-calendar-aurora?(philipp)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8842076 [details] [diff] [review]
1343286-universalremove.patch
Review of attachment 8842076 [details] [diff] [review]:
-----------------------------------------------------------------
As this is only a removal I don't think we need to uplift this. But if you want, blanket a+ on all repos where it is unused.
Attachment #8842076 -
Flags: review?(philipp)
Attachment #8842076 -
Flags: review+
Attachment #8842076 -
Flags: approval-calendar-aurora?(philipp)
|
|
||
Updated•8 years ago
|
Priority: -- → P5
|
|
Assignee | |
Comment 3•8 years ago
|
||
> As this is only a removal I don't think we need to uplift this.
Agreeed. comm-esr52 still has universal builds and for the other two let it ride the train.
https://hg.mozilla.org/comm-central/rev/09f4a64c933abae2079964efc050796e546f4c4d
Target Milestone: --- → 5.7
|
|
Assignee | |
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•