1343293 - Trees didn't auto-close when TreeStatus UI was not working

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Treeherder doesn't show new pushes, there are S3 issues, so likely release automation doesn't emit data. According to RyanVM, trees are supposed to autoclose, but that didn't happen.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Rok, can you take a look, please?

Comment 2

[Ed Morley [:emorley]]

> According to RyanVM, trees are supposed to autoclose, but that didn't happen.

The hg hook that accepts/denies pushes defaults to deny if it can't reach the treestatus API:
https://github.com/mozilla/version-control-tools/blob/master/hghooks/mozhghooks/treeclosure.py#L55

However in this case the API is accessible, just not the new Cloudfront/S3 backed Treestatus UI that sheriffs use to close the trees:
https://mozilla-releng.net/treestatus

Comment 3

[hwine]

I believe this will be handled by both:
 - bug 1343334 (change to the hooks) and 
 - https://github.com/mozilla-releng/services/issues/148 (changes to Treestatus)

This bug could be converted to the tracker.

Comment 4

[Rok Garbas [:garbas]]

:aryx sorry for late reply, I talked to :hwine since I lacked the bigger picture.

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

Found in triaging. Is this something we still need to look into? Trying to understand if this is the right component.

Comment 6

[Ed Morley [:emorley]]

Adjusting summary to remove Treeherder references since this has nothing to do with Treeherder.

This somewhat overlaps with bug 1343334, which is currently a dep but this could perhaps be duped to it?

The questions are:
* should the TreeStatus UI being broken make the trees automatically close even if the API is still working?
* if so, how? Either by making the hg.m.o tree closure hook detect this, or else making the treestatus API do so? bug 1343334 didn't seem to like the sound of either.
* if not, how do people manually close the trees if the UI is down? perhaps a CLI to interact with the API as a fallback?

Comment 7

[Mihai Tabara [:mtabara]⌚️GMT]

Thanks for fast turnaround :emorley!
Sounds like this is a TreeStatus bug. Moving it there ;-)

Comment 8

[Rok Garbas [:garbas]]

This was already implemented from the Treestatus end. I'm closing this since there is already a bug opened (Bug 1343334) to handle this properly in hg hooks.