1343357 - Assertion failure: startParams.mPath == endParams.mPath (unexpected path mismatch)

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Schwartzentruber (:truber)]

Attachment: testcase.svg

The attached testcase causes an assertion failure in mozilla-central rev 1bc2ad020aee.

Assertion failure: startParams.mPath == endParams.mPath (unexpected path mismatch), at /home/worker/workspace/build/src/dom/svg/SVGMotionSMILType.cpp:430
#01: nsSMILAnimationFunction::InterpolateResult at dom/smil/nsSMILAnimationFunction.cpp:445
#02: nsSMILAnimationFunction::ComposeResult at dom/smil/nsSMILAnimationFunction.cpp:263
#03: nsSMILCompositor::ComposeAttribute at dom/smil/nsSMILCompositor.cpp:97
#04: nsSMILAnimationController::DoSample at dom/smil/nsSMILAnimationController.cpp:452
#05: nsSMILTimeContainer::Sample at dom/smil/nsSMILTimeContainer.cpp:185
#06: nsDocument::OnPageShow at dom/base/nsDocument.cpp:8907
#07: nsDocumentViewer::LoadComplete at layout/base/nsDocumentViewer.cpp:1063
#08: nsDocShell::EndPageLoad at docshell/base/nsDocShell.cpp:7637
#09: nsDocShell::OnStateChange at docshell/base/nsDocShell.cpp:7430
#10: nsDocLoader::DoFireOnStateChange at uriloader/base/nsDocLoader.cpp:1258
#11: nsDocLoader::doStopDocumentLoad at uriloader/base/nsDocLoader.cpp:841
#12: nsDocLoader::DocLoaderIsEmpty at uriloader/base/nsDocLoader.cpp:734
#13: nsDocLoader::OnStopRequest at uriloader/base/nsDocLoader.cpp:614
#14: mozilla::net::nsLoadGroup::RemoveRequest at netwerk/base/nsLoadGroup.cpp:636
#15: nsDocument::DoUnblockOnload at dom/base/nsDocument.cpp:8818
#16: nsDocument::UnblockOnload at dom/base/nsDocument.cpp:8743
#17: nsDocument::DispatchContentLoadedEvents at dom/base/nsDocument.cpp:5202

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Still reproducible on trunk. Assertion goes back more than a year.

Comment 2

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

Marking as wontfix for 62, I'd take a low-risk patch for 63 if it doesn't come late in the beta cycle.

Comment 4

[violet.bugreport]

Attachment: Bug 1343357 - Ignore lower-priority animateMotion if a to-animation is encountered

When there are lower-priority animations than a to-animation, our impl will
pass the current value from previous function to to-animation as start value,
this will cause a assertion failure because the start and end value will end up
in different paths. Our impl doesn't really support the interaction between
to-animation and lower-priority ones as described in the spec. Moreover, neither
Chrome nor Safari is compliant. Now we use the same behavior as Chrome and
Safari, i.e. ignore those lower-priority ones.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8854d4a16528
Ignore lower-priority animateMotion if a to-animation is encountered r=dholbert

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/8854d4a16528

Comment 10

[Daniel Holbert [:dholbert]]

Thanks for fixing this, violet!