1343360 - Devtools toggle split console tooltip shows %S instead of the keyboard shortcut

Status: RESOLVED FIXED

(DevTools :: General, defect, P1)

Description

[Michael Hoffmann]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170226084138

Steps to reproduce:

Show the web developer tools, hover over the "Toggle split console" button.


Actual results:

Tooltip shows "Toggle split console (%S)"


Expected results:

Tooltip should show "Toggle split console (Esc)"

Comment 1

[Michael Hoffmann]

The keyboard shortcut disappeared when Bug 1320149 was fixed.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1343360 - Fix tooltip for 'Toggle split console' button, add back 'Esc'.

Review commit: https://reviewboard.mozilla.org/r/116118/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116118/

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8842218 [details]
Bug 1343360 - Fix tooltip for 'Toggle split console' button, add back 'Esc'.

https://reviewboard.mozilla.org/r/116118/#review120974

Awesome, you can land this now.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0183705be054
Fix tooltip for 'Toggle split console' button, add back 'Esc'. r=miker

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

[Tracking Requested - why for this release]:

Regression here makes things look unpolished, let's try to uplift.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0183705be054

Comment 7

[Julien Cristau [:jcristau]]

Tracking as new regression in 54.

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8842218 [details]
Bug 1343360 - Fix tooltip for 'Toggle split console' button, add back 'Esc'.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1320149 dropped some text about the key used for this action
[User impact if declined]: If declined, a tooltip will look unpolished
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only affects DevTools tooltip
[String changes made/needed]: Not a string file, text is in code directly

Comment 9

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 54.0a1 (2017-02-28) (64-bit) on Windows 7 , 64 Bit!

This bug's fix is verified with latest Nightly!

Build ID   : 20170317030204
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170315]

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8842218 [details]
Bug 1343360 - Fix tooltip for 'Toggle split console' button, add back 'Esc'.

Polish a tooltip issue and was verified. Aurora54+.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fb2b0adb7b2b

Comment 12

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 54.0a1 (2017-02-28) (64-bit) on Windows 7 , 64 Bit!

This bug's fix is verified with latest Developer Edition(Aurora)!

Build ID   : 20170413004024
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0

[bugday-20170412]