1343366 - browser_parsable_css.js fails on ESR52 ASAN builds due to the ESR branding changes

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

On every new ESR branch, branding changes are landed to s/Firefox/Firefox ESR the main About dialog.
https://hg.mozilla.org/releases/mozilla-esr52/rev/df0931ac8b02943468f236483f2cb5a53bb0b439

With ESR52, this change is currently causing browser_parseable_css.js to fail on ASAN builds because the About dialog changes only work with official branding, which they don't have enabled.
https://treeherder.mozilla.org/logviewer.html#?job_id=80540438&repo=mozilla-esr52

This means that ESR ASAN builds almost certainly have a legitimately broken About dialog. But given that they aren't builds we officially distribute anyway, I'm not sure we really care. So our options here are probably either adding an exception to the test for this issue or just skipping it outright on ASAN.

Having talked it over with Jared on IRC, it seems highly unlikely that ASAN builds are going to catch an issue on uplifts that other platforms wouldn't also catch (other than this one, apparently!), so I'm going to just skip the test on ASAN.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/af75aa20f686