Add missing CSS variable for debugger.html

VERIFIED FIXED in Firefox 54

Status

()

Firefox
Developer Tools: Shared Components
VERIFIED FIXED
5 months ago
3 months ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

unspecified
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
See issue: https://github.com/devtools-html/devtools-core/issues/220

debugger.html (or devtools-core in this case) defines the css variable --theme-comment-alt in its copy of variables.css but this was never ported to mozilla-central.

The values set in devtools core for this variable are:
- light: #ccd1d5
- dark: #5a6375
- firebug: #ccd1d5

Since the firebug theme "extends" the light theme and the same value is defined for both, we should only define it for light and dark.
Comment hidden (mozreview-request)

Comment 2

5 months ago
mozreview-review
Comment on attachment 8842356 [details]
Bug 1343478 - add missing css variables from devtools.html to variables.css;

https://reviewboard.mozilla.org/r/116224/#review117852
Attachment #8842356 - Flags: review?(jlaster) → review+
Comment hidden (mozreview-request)

Comment 4

5 months ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e28df8c208a0
add missing css variables from devtools.html to variables.css;r=jlast

Comment 5

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e28df8c208a0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54

Comment 6

3 months ago
I have reproduced this issue on Firefox nightly according to (2017-03-01)

Fixing bug is verified on Latest Developer Edition--- Build ID: (20170427004028),User Agent: Mozilla/5.0 (Windows NT 6.1; rv:54.0) Gecko/20100101 Firefox/54.0

Tested OS-- Windows7 32bit
[testday-20170428]

Updated

3 months ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.