1343479 - gfx-labeling Label runnables in apz.

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Vincent Liu[:vliu]]

See https://wiki.mozilla.org/Quantum/DOM#Labeling for the story. Currently runnable categories in apz include

  1. NS_DispatchToMainThread()
     => http://searchfox.org/mozilla-central/search?q=NS_DispatchToMainThread&case=false&regexp=true&path=layers%2Fapz
  2. InitWithCallback()
     => http://searchfox.org/mozilla-central/search?q=InitWithCallback&regexp=true&path=layers%2Fapz%2F
  3. ipc for apz.
    => ./gfx/layers/ipc/PAPZ.ipdl
    => ./gfx/layers/ipc/PAPZCTreeManager.ipdl

Comment 1

[Kevin Chen[:kechen] (UTC + 8)]

Attachment: Bug 1343479 - Label the tasks for APZ module.

Review commit: https://reviewboard.mozilla.org/r/122982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122982/

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8850353 [details]
Bug 1343479 - Label the tasks for APZ module.

https://reviewboard.mozilla.org/r/122982/#review125236

::: gfx/layers/apz/util/APZEventState.cpp:211
(Diff revision 1)
>    }
>  
>    APZES_LOG("Active element uses style, scheduling timer for click event\n");
>    nsCOMPtr<nsITimer> timer = do_CreateInstance(NS_TIMER_CONTRACTID);
> +
> +  if (XRE_IsContentProcess() && widget->GetOwningTabChild()) {

nit:

if (TabChild* tabChild = widget->GetOwningTabChild() && 
    XRE_IsContentProcess()) {
  timer->SetTarget(tabChild->TabGroup()->EventTargetFor(TaskCategory::Other));
}

Comment 3

[Kevin Chen[:kechen] (UTC + 8)]

Comment on attachment 8850353 [details]
Bug 1343479 - Label the tasks for APZ module.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122982/diff/1-2/

Comment 4

[Kevin Chen[:kechen] (UTC + 8)]

After the investigation, the DispatchToMainThread functions in [1] are in parent process; therefore I didn't labeled these functions.
Please correct me if my understanding is not correct.

Thank you.

[1] http://searchfox.org/mozilla-central/search?q=NS_DispatchToMainThread&case=false&regexp=true&path=layers%2Fapz

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8850353 [details]
Bug 1343479 - Label the tasks for APZ module.

https://reviewboard.mozilla.org/r/122982/#review125912

This patch looks fine to me.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

(In reply to Kevin Chen[:kechen] (UTC + 8) from comment #4)
> After the investigation, the DispatchToMainThread functions in [1] are in
> parent process; therefore I didn't labeled these functions.
> Please correct me if my understanding is not correct.
> 
> Thank you.
> 
> [1]
> http://searchfox.org/mozilla-central/
> search?q=NS_DispatchToMainThread&case=false&regexp=true&path=layers%2Fapz

Almost all of these are in the parent process (or the GPU process, if there is a GPU process), yes. The only one that runs in the content process is the one at http://searchfox.org/mozilla-central/rev/c48398abd9f0f074c69f2223260939e30e8f99a8/gfx/layers/apz/util/ContentProcessController.cpp#109 but looking at the code I think that function will never actually get called so you should be ok. We can even replace the implementation with a MOZ_RELEASE_ASSERT(false) or something and I think we should be ok.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ff9768569a4
Label the tasks for APZ module. r=bevistseng,kats

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3ff9768569a4