1343571 - The delay is not applied and the action is triggered from the first click on a notification when the window is refocus

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[ovidiu boca[:Ovidiu]]

This bug was filled after a discussion with Florian on https://bugzilla.mozilla.org/show_bug.cgi?id=1335985#c19

It is a specific issue, reproducible only on Linux. 

[Affected versions]:

Tested on Nightly 54.0a1(2017-03-01)

[Affected platforms]:

Only Linux, tested on Ubuntu 16.04 x64

[Steps to reproduce]:

1. From about:config, set security.notification_enable_delay to a higher value.
2. Open 2 browser windows.
3. In 1 window go to http://permission.site/  and click the 'microphone' button
4. Move focus to the second window.
5. Click on "Allow" in the first window.

[Expected result]:

The delay is applied and only on the second click on "Allow" the button is triggered

[Actual result]:

The "Allow" button is triggered on the first click.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

I think detecting that the window isn't focused, ignoring the click and focusing the window is all we need to do. I don't think this edge case is important enough to be worth uplifting, and I'm also not convinced it's worth spending time to write a test for this.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8847719 [details] [diff] [review]
Patch

Review of attachment 8847719 [details] [diff] [review]:
-----------------------------------------------------------------

Agreed.

Comment 3

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/34554df9f50cb34482838c1200fea11cb87b9095
Bug 1343571 - When clicking an action button of a PopupNotification in an inactive window, focus the window instead of performing the action, r=past.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/34554df9f50c

Comment 5

[ovidiu boca[:Ovidiu]]

I verified this on Ubuntu 16.04 with FF Nightly 55.0a1(2017-04-10) and I can't reproduce the issue. I will mark this as a verified fix.

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

wontfix for 54 per comment 1.

Comment 7

[reikred]

(In reply to Wes Kocher (:KWierso) from comment #4)
> https://hg.mozilla.org/mozilla-central/rev/34554df9f50c

Please beware that the above "fix" caused the bug https://bugzilla.mozilla.org/show_bug.cgi?id=1399937