1343627 - 500 status code pushing to mozreview from git

Status: RESOLVED DUPLICATE of bug 1338530

(MozReview Graveyard :: Integration: Git, defect)

Description

[Andreas Tolfsen ❲:ato❳]

When pushing https://reviewboard.mozilla.org/r/113504/ to mozreview this evening, I received a 500 status code from mozreview:

% git mozreview push
adding changesets
adding manifests
adding file changes
added 5 changesets with 4 changes to 736 files (+1 heads)
recorded push in pushlog

submitting 5 commits for review
error: non-200 HTTP status code (500) when submitting series
% date
Wed  1 Mar 19:43:33 GMT 2017

Comment 1

[Andreas Tolfsen ❲:ato❳]

Then when I tried pushing again:

% git mozreview push
Traceback (most recent call last):
  File "/home/ato/.mozbuild/version-control-tools/git/cinnabar-debug-push.py", line 103, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/home/ato/.mozbuild/version-control-tools/git/cinnabar-debug-push.py", line 72, in main
    pushed = push(repo, store, {commit: (None, False)}, heads, ())
  File "/home/ato/src/git-cinnabar/cinnabar/hg/__init__.py", line 674, in push
    reply = repo.unbundle(cg, repo_heads, '')
  File "/usr/local/lib/python2.7/dist-packages/mercurial/wireproto.py", line 376, in unbundle
    ret = bundle2.getunbundler(self.ui, stream)
  File "/usr/local/lib/python2.7/dist-packages/mercurial/bundle2.py", line 639, in getunbundler
    raise error.Abort(_('not a Mercurial bundle'))
mercurial.error.Abort: not a Mercurial bundle
abort: error performing cinnabar push; please report this bug

Comment 2

[Andreas Tolfsen ❲:ato❳]

Third through seventh attempt follows.

It says “0 changesets with 0 changes” this time, which leads me to wonder if it fails before the review publishing question?  If I visit https://reviewboard.mozilla.org/r/113504/, the changes have made it on to the server but are not published.

% git mozreview push
Traceback (most recent call last):
  File "/home/ato/.mozbuild/version-control-tools/git/cinnabar-debug-push.py", line 103, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/home/ato/.mozbuild/version-control-tools/git/cinnabar-debug-push.py", line 72, in main
    pushed = push(repo, store, {commit: (None, False)}, heads, ())
  File "/home/ato/src/git-cinnabar/cinnabar/hg/__init__.py", line 674, in push
    reply = repo.unbundle(cg, repo_heads, '')
  File "/usr/local/lib/python2.7/dist-packages/mercurial/wireproto.py", line 376, in unbundle
    ret = bundle2.getunbundler(self.ui, stream)
  File "/usr/local/lib/python2.7/dist-packages/mercurial/bundle2.py", line 639, in getunbundler
    raise error.Abort(_('not a Mercurial bundle'))
mercurial.error.Abort: not a Mercurial bundle
abort: error performing cinnabar push; please report this bug
% date
Wed  1 Mar 19:47:52 GMT 2017
% time git mozreview push
adding changesets
adding manifests
adding file changes
added 0 changesets with 0 changes to 736 files

submitting 5 commits for review
error: non-200 HTTP status code (500) when submitting series
4.71u 0.40s 76.82r 	 git mozreview push  # status=1
% date
Wed  1 Mar 19:49:27 GMT 2017
% time git mozreview push
adding changesets
adding manifests
adding file changes
added 0 changesets with 0 changes to 736 files

submitting 5 commits for review
error: non-200 HTTP status code (500) when submitting series
4.82u 0.34s 76.77r 	 git mozreview push  # status=1
% date
Wed  1 Mar 19:51:08 GMT 2017
% time git mozreview push
adding changesets
adding manifests
adding file changes
added 0 changesets with 0 changes to 736 files

submitting 5 commits for review
error: non-200 HTTP status code (500) when submitting series
4.73u 0.49s 83.16r 	 git mozreview push  # status=1
% date
Wed  1 Mar 19:52:48 GMT 2017
%  time git mozreview push
adding changesets
adding manifests
adding file changes
added 0 changesets with 0 changes to 736 files

submitting 5 commits for review
error: non-200 HTTP status code (500) when submitting series
4.83u 0.45s 83.37r 	 git mozreview push  # status=1
% date
Wed  1 Mar 19:54:28 GMT 2017
% time git mozreview push
adding changesets
adding manifests
adding file changes
added 0 changesets with 0 changes to 736 files

submitting 5 commits for review
error: non-200 HTTP status code (500) when submitting series
4.78u 0.41s 81.63r 	 git mozreview push  # status=1
% date
Wed  1 Mar 19:56:06 GMT 2017

Comment 3

[:glob ✱]

weird - the request completed without errors server-side:

2017-03-01 19:42:35,085 - INFO -  - Login attempt (apikey) for user [e-mail]:
2017-03-01 19:42:35,466 - INFO -  - Login successful (apikey) for user [e-mail]:
2017-03-01 19:42:35,476 - INFO -  - processing BatchReviewRequest for ato+446296
2017-03-01 19:42:35,642 - INFO -  - processing batch submission bz://1340637/ato to gecko with 5 commits
2017-03-01 19:42:35,647 - INFO -  - using squashed review request 113504
2017-03-01 19:42:35,647 - INFO -  - bz://1340637/ato: generating squashed diffset for 113504
2017-03-01 19:42:49,385 - INFO -  - bz://1340637/ato: updated squashed diffset for 113504
2017-03-01 19:42:49,387 - INFO -  - bz://1340637/ato: 3 previous commits; 0 discard on publish; 0 unpublished
2017-03-01 19:42:49,387 - INFO -  - bz://1340637/ato: 0/5 commits mapped exactly
2017-03-01 19:42:49,387 - INFO -  - bz://1340637/ato: 0/5 mapped exactly or to precursors
2017-03-01 19:42:49,393 - INFO -  - bz://1340637/ato: commit ID 2UT27GgxYpu for 30629978e190c8ece3b73ed3eff60485812e09d3 found in review request 113506
2017-03-01 19:42:50,566 - INFO -  - importing Bugzilla users from query "jgraham": ..
2017-03-01 19:42:53,982 - INFO -  - importing Bugzilla users from query "ted": ..
2017-03-01 19:42:55,006 - INFO -  - bz://1340637/ato: commit ID 1sNFp8hvIb0 for 2842acffe6fe6e01fb9e81c223087bd3c825e533 found in review request 113508
2017-03-01 19:42:55,261 - INFO -  - bz://1340637/ato: commit ID 477AYtneVer for 0618a41e2fa117378ce7239eb5ac6e8847d43e9a found in review request 113510
2017-03-01 19:43:07,780 - INFO -  - bz://1340637/ato: 3/5 mapped after commit ID matching
2017-03-01 19:43:07,780 - INFO -  - bz://1340637/ato: 0 unclaimed review requests
2017-03-01 19:43:07,801 - INFO -  - bz://1340637/ato: created review request 116340 for commit 875c5c8e67117d58d637fc6d4e551e90e9cb1abe
2017-03-01 19:43:09,033 - INFO -  - importing Bugzilla users from query "sfink": ..
2017-03-01 19:43:09,727 - INFO -  - bz://1340637/ato: created review request 116342 for commit ac5e79e7c176e72f8adb02aa3604cbb4d775f8f7
2017-03-01 19:43:09,962 - INFO -  - bz://1340637/ato: 0 unclaimed review requests left over
2017-03-01 19:43:10,022 - INFO -  - bz://1340637/ato: finished processing 113504

Comment 4

[:glob ✱]

same for all your later attempts:

2017-03-01 19:49:25,320 - INFO -  - bz://1340637/ato: finished processing 113504
2017-03-01 19:50:56,924 - INFO -  - bz://1340637/ato: finished processing 113504
2017-03-01 19:52:44,618 - INFO -  - bz://1340637/ato: finished processing 113504
2017-03-01 19:54:26,995 - INFO -  - bz://1340637/ato: finished processing 113504
2017-03-01 19:56:09,198 - INFO -  - bz://1340637/ato: finished processing 113504


glandium - is there any way to increase the verbosity of cinnabar?

Comment 5

[Mike Hommey [:glandium]]

cinnabar is not responsible for talking to reviewboard and submitting the review. The git-mozreview code in v-c-t is.

(In reply to Andreas Tolfsen ‹:ato› from comment #1)
> Then when I tried pushing again:
> 
> % git mozreview push
> Traceback (most recent call last):
>   File
> "/home/ato/.mozbuild/version-control-tools/git/cinnabar-debug-push.py", line
> 103, in <module>
>     sys.exit(main(sys.argv[1:]))
>   File
> "/home/ato/.mozbuild/version-control-tools/git/cinnabar-debug-push.py", line
> 72, in main
>     pushed = push(repo, store, {commit: (None, False)}, heads, ())
>   File "/home/ato/src/git-cinnabar/cinnabar/hg/__init__.py", line 674, in
> push
>     reply = repo.unbundle(cg, repo_heads, '')
>   File "/usr/local/lib/python2.7/dist-packages/mercurial/wireproto.py", line
> 376, in unbundle
>     ret = bundle2.getunbundler(self.ui, stream)
>   File "/usr/local/lib/python2.7/dist-packages/mercurial/bundle2.py", line
> 639, in getunbundler
>     raise error.Abort(_('not a Mercurial bundle'))
> mercurial.error.Abort: not a Mercurial bundle
> abort: error performing cinnabar push; please report this bug

This one I've seen in the past, and I'm not sure what's going on. I wish I could capture it under rr... I guess I should just run all my git pushes through rr until it happens again...

(In reply to Andreas Tolfsen ‹:ato› from comment #2)
> Third through seventh attempt follows.
> 
> It says “0 changesets with 0 changes” this time, which leads me to wonder if
> it fails before the review publishing question?

FWIW, that part just means you're pushing something the mercurial server already has.

Comment 6

[Andreas Tolfsen ❲:ato❳]

(In reply to Mike Hommey [:glandium] from comment #5)

> > mercurial.error.Abort: not a Mercurial bundle abort: error
> > performing cinnabar push; please report this bug
>
> This one I've seen in the past, and I'm not sure what's going on. I
> wish I could capture it under rr... I guess I should just run all my
> git pushes through rr until it happens again...

I don’t even know where to begin debugging this, but it is my
subjective impression that I see this more frequently late at night in
Europe, when California wakes up.  Could it be related to mozreview
usage/load?

Comment 7

[:glob ✱]

looks like reviewboard-hg2 is throwing the 500, tracking in bug 1338530.