1343713 - Avoid mozconfig failures when tooltool packages have not been unpacked yet

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

For bug 1313111, I want to introduce a mach command to, first, replace tooltool (a wrapper of some sort), that would be augmented to download taskcluster artifacts from toolchain tasks for toolchains that come from there.

Using mach ends up evaluating mozconfigs, and doing that before the tooltool packages have been downloaded and unpacked currently fails because the mozconfigs exit with errors when the toolchain directories are not there (In most case, this is because of a (cd $path; pwd) construct for windows)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1343713 - Avoid mozconfig failure when sccache is not there.

The build will fail during configure anyways in that case, not silently
fallback to compiling without it.

Review commit: https://reviewboard.mozilla.org/r/116442/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116442/

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1343713 - Avoid mozconfig failures when clang-cl/msvc are not present.

The `cd $PATH && pwd` pattern doesn't work when $PATH doesn't exist, so
move them in a block only executed when the directory exists.

Review commit: https://reviewboard.mozilla.org/r/116444/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116444/

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8842679 [details]
Bug 1343713 - Avoid mozconfig failure when sccache is not there.

https://reviewboard.mozilla.org/r/116442/#review118690

Things are definitely better now that we do sensible checks in moz.configure!

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8842680 [details]
Bug 1343713 - Avoid mozconfig failures when clang-cl/msvc are not present.

https://reviewboard.mozilla.org/r/116444/#review118692

So this will get re-evaluated in `mach build` after your tooltool-replacement runs and the tools are present, right?

It'd be nice to figure out some less-ugly ways to deal with the mozconfig logic these days. Using shell scripts is just not that good.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dcda6d41df1
Avoid mozconfig failure when sccache is not there. r=ted
https://hg.mozilla.org/integration/autoland/rev/bc2f8a0c7d9a
Avoid mozconfig failures when clang-cl/msvc are not present. r=ted

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1dcda6d41df1
https://hg.mozilla.org/mozilla-central/rev/bc2f8a0c7d9a