Closed
Bug 1343716
Opened 7 years ago
Closed 7 years ago
Use Windows style paths for TOOLTOOL_CACHE
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
Currently, tooltool is a python script, but when called from mozharness, it's wrapped with a shell script. What happens is that mozharness gets the msys-style paths, passes them to the shell script, then the shell script calls the python tooltool, and the transition msys->win32 makes that call use windows style paths. For bug 1313111, I want to replace tooltool with a mach command, and the shell script would go away. Calling a mach command (or python tooltool, for that matter) directly from mozharness with a msys-style path doesn't work. OTOH, calling the current shell script with a Windows style path (with forward slashes, for good measure) does work, and is future-proof.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
Note that in theory, we should be able to replace all the msys paths in the mozharness configs similarly, but I didn't want to scope bloat my patch queue, or having to figure out what might break or not.
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8842683 [details] Bug 1343716 - Use Windows style paths for TOOLTOOL_CACHE. https://reviewboard.mozilla.org/r/116448/#review118298
Attachment #8842683 -
Flags: review?(mshal) → review+
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/482d93aa283a Use Windows style paths for TOOLTOOL_CACHE. r=mshal
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/482d93aa283a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•