1343716 - Use Windows style paths for TOOLTOOL_CACHE

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

Currently, tooltool is a python script, but when called from mozharness, it's wrapped with a shell script. What happens is that mozharness gets the msys-style paths, passes them to the shell script, then the shell script calls the python tooltool, and the transition msys->win32 makes that call use windows style paths.

For bug 1313111, I want to replace tooltool with a mach command, and the shell script would go away. Calling a mach command (or python tooltool, for that matter) directly from mozharness with a msys-style path doesn't work.

OTOH, calling the current shell script with a Windows style path (with forward slashes, for good measure) does work, and is future-proof.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1343716 - Use Windows style paths for TOOLTOOL_CACHE.

Currently, tooltool is a python script, but when called from mozharness,
it's wrapped with a shell script. What happens is that mozharness gets
the msys-style paths, passes them to the shell script, then the shell
script calls the python tooltool, and the transition msys->win32 makes
that call use windows style paths.

For bug 1313111, I want to replace tooltool with a mach command, and the
shell script would go away. Calling a mach command (or python tooltool,
for that matter) directly from mozharness with a msys-style path doesn't
work.

OTOH, calling the current shell script with a Windows style path (with
forward slashes, for good measure) does work, and is future-proof.

Review commit: https://reviewboard.mozilla.org/r/116448/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116448/

Comment 2

[Mike Hommey [:glandium]]

Note that in theory, we should be able to replace all the msys paths in the mozharness configs similarly, but I didn't want to scope bloat my patch queue, or having to figure out what might break or not.

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8842683 [details]
Bug 1343716 - Use Windows style paths for TOOLTOOL_CACHE.

https://reviewboard.mozilla.org/r/116448/#review118298

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/482d93aa283a
Use Windows style paths for TOOLTOOL_CACHE. r=mshal

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/482d93aa283a