1343758 - gfx-labeling Label runnables in gfx vr.

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Vincent Liu[:vliu]]

See https://wiki.mozilla.org/Quantum/DOM#Labeling for the story. Currently runnable categories in gfx vr include sending ipc message between content and parent side [1].   

  ./gfx/vr/ipc/PVRLayer.ipdl
  ./gfx/vr/ipc/PVRManager.ipdl

  [1]; https://hg.mozilla.org/mozilla-central/annotate/e150eaff1f83e4e4a97d1e30c57d233859efe9cb/ipc/chromium/src/base/message_loop.cc#l286

Comment 1

[Kevin Chen[:kechen] (UTC + 8)]

Attachment: Bug 1343758 - Label the tasks in vr module.

Review commit: https://reviewboard.mozilla.org/r/122986/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122986/

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8850356 [details]
Bug 1343758 - Label the tasks in vr module.

https://reviewboard.mozilla.org/r/122986/#review125238

::: gfx/vr/VRDisplayPresentation.cpp:78
(Diff revision 1)
>  
> -    RefPtr<VRLayerChild> vrLayer = static_cast<VRLayerChild*>(manager->CreateVRLayer(mDisplayClient->GetDisplayInfo().GetDisplayID(), leftBounds, rightBounds));
> +    nsCOMPtr<nsIEventTarget> target;
> +    nsIDocument* doc;
> +    doc = canvasElement->OwnerDoc();
> +    if (doc) {
> +      target = doc->GetDocGroup()->EventTargetFor(TaskCategory::Other);

nit:
target = doc->EventTargetFor(TaskCategory::Other);

Comment 3

[Kevin Chen[:kechen] (UTC + 8)]

Comment on attachment 8850356 [details]
Bug 1343758 - Label the tasks in vr module.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122986/diff/1-2/

Comment 4

[Kevin Chen[:kechen] (UTC + 8)]

VRManagerChild doesn't belong to any tab or document, it is bound with process like CompositorBridgeChild.
The current mechanism can not support this kind of ipc so I won't label it in this bug.

Comment 5

[:kip (Kearwood Gilbert)]

Comment on attachment 8850356 [details]
Bug 1343758 - Label the tasks in vr module.

https://reviewboard.mozilla.org/r/122986/#review126026

r=me with nit from bevistseng

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccf27d7cdcdc
Label the tasks in vr module. r=bevistseng,kip

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ccf27d7cdcdc