If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

gfx-labeling Label runnables in gfx vr.

RESOLVED FIXED in Firefox 55

Status

()

Core
Graphics
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: vliu, Assigned: kechen)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [gfx-noted][QDL][TDC-MVP][GFX])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
See https://wiki.mozilla.org/Quantum/DOM#Labeling for the story. Currently runnable categories in gfx vr include sending ipc message between content and parent side [1].   

  ./gfx/vr/ipc/PVRLayer.ipdl
  ./gfx/vr/ipc/PVRManager.ipdl

  [1]; https://hg.mozilla.org/mozilla-central/annotate/e150eaff1f83e4e4a97d1e30c57d233859efe9cb/ipc/chromium/src/base/message_loop.cc#l286
(Reporter)

Updated

8 months ago
Blocks: 1341537

Updated

8 months ago
Whiteboard: [gfx-noted]
(Assignee)

Updated

7 months ago
Assignee: nobody → kechen
Comment hidden (mozreview-request)

Comment 2

7 months ago
mozreview-review
Comment on attachment 8850356 [details]
Bug 1343758 - Label the tasks in vr module.

https://reviewboard.mozilla.org/r/122986/#review125238

::: gfx/vr/VRDisplayPresentation.cpp:78
(Diff revision 1)
>  
> -    RefPtr<VRLayerChild> vrLayer = static_cast<VRLayerChild*>(manager->CreateVRLayer(mDisplayClient->GetDisplayInfo().GetDisplayID(), leftBounds, rightBounds));
> +    nsCOMPtr<nsIEventTarget> target;
> +    nsIDocument* doc;
> +    doc = canvasElement->OwnerDoc();
> +    if (doc) {
> +      target = doc->GetDocGroup()->EventTargetFor(TaskCategory::Other);

nit:
target = doc->EventTargetFor(TaskCategory::Other);
Attachment #8850356 - Flags: review?(btseng) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 4

7 months ago
VRManagerChild doesn't belong to any tab or document, it is bound with process like CompositorBridgeChild.
The current mechanism can not support this kind of ipc so I won't label it in this bug.

Comment 5

7 months ago
mozreview-review
Comment on attachment 8850356 [details]
Bug 1343758 - Label the tasks in vr module.

https://reviewboard.mozilla.org/r/122986/#review126026

r=me with nit from bevistseng
Attachment #8850356 - Flags: review?(kgilbert) → review+

Comment 6

7 months ago
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ccf27d7cdcdc
Label the tasks in vr module. r=bevistseng,kip

Comment 7

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ccf27d7cdcdc
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Whiteboard: [gfx-noted] → [gfx-noted][QDL][TDC-MVP][GFX]
You need to log in before you can comment on or make changes to this bug.